[Misc] Move M-RoPE init logic to _init_mrope_positions #23422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Woosuk Kwon <[email protected]>
WoosukKwon
requested review from
robertgshaw2-redhat,
njhill,
ywang96,
comaniac and
alexm-redhat
as code owners
WoosukKwon
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the M-RoPE initialization logic from the _update_states method into a new dedicated private method, _init_mrope_positions. This is a good code improvement that enhances readability and modularity by isolating a specific piece of functionality. The implementation is a direct move of the existing logic, so correctness is maintained and there are no performance implications. Overall, this is a clean and beneficial refactoring.
FFFfff1FFFfff
pushed a commit
to FFFfff1FFFfff/my_vllm
that referenced
this pull request
Aug 25, 2025
…23422) Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: FFFfff1FFFfff <[email protected]>
epwalsh
pushed a commit
to epwalsh/vllm
that referenced
this pull request
Aug 28, 2025
…23422) Signed-off-by: Woosuk Kwon <[email protected]>
juuice-lee
pushed a commit
to juuice-lee/vllm-moe.code
that referenced
this pull request
Aug 28, 2025
…23422) Signed-off-by: Woosuk Kwon <[email protected]>
xiao-llm
pushed a commit
to xiao-llm/vllm
that referenced
this pull request
Aug 28, 2025
…23422) Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
xiao-llm
pushed a commit
to xiao-llm/vllm
that referenced
this pull request
Aug 28, 2025
…23422) Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Aug 28, 2025
…23422) Signed-off-by: Woosuk Kwon <[email protected]>
dumb0002
pushed a commit
to dumb0002/vllm
that referenced
this pull request
Aug 28, 2025
…23422) Signed-off-by: Woosuk Kwon <[email protected]>
2015aroras
pushed a commit
to 2015aroras/vllm
that referenced
this pull request
Aug 29, 2025
…23422) Signed-off-by: Woosuk Kwon <[email protected]>
mengxingkongzhouhan
pushed a commit
to mengxingkongzhouhan/vllm
that referenced
this pull request
Aug 30, 2025
…23422) Signed-off-by: Woosuk Kwon <[email protected]>
mengxingkongzhouhan
pushed a commit
to mengxingkongzhouhan/vllm
that referenced
this pull request
Aug 30, 2025
…23422) Signed-off-by: Woosuk Kwon <[email protected]>
mengxingkongzhouhan
pushed a commit
to mengxingkongzhouhan/vllm
that referenced
this pull request
Aug 30, 2025
…23422) Signed-off-by: Woosuk Kwon <[email protected]>
mengxingkongzhouhan
pushed a commit
to mengxingkongzhouhan/vllm
that referenced
this pull request
Aug 30, 2025
…23422) Signed-off-by: Woosuk Kwon <[email protected]>
mengxingkongzhouhan
pushed a commit
to mengxingkongzhouhan/vllm
that referenced
this pull request
Aug 30, 2025
…23422) Signed-off-by: Woosuk Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple code cleanup.