Skip to content

[Misc] local import code clean #23420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

[Misc] local import code clean #23420

merged 1 commit into from
Aug 22, 2025

Conversation

andyxning
Copy link
Contributor

@andyxning andyxning commented Aug 22, 2025 •
edited by github-actions bot
Loading

Purpose

local import code clean

Test Plan

NA

Test Result

NA

(Optional) Documentation Update

NA

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

@mergify mergify bot added the v1 label Aug 22, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 22, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up local imports of contextlib.nullcontext by moving them to the top level of the files. This is a good refactoring that improves code readability and consistency. The changes in vllm/v1/worker/gpu_worker.py and vllm/worker/worker.py are correct and follow best practices. I have reviewed the changes and found no issues.

DarkLight1337
DarkLight1337 approved these changes Aug 22, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 22, 2025 12:02
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 22, 2025
@DarkLight1337 DarkLight1337 merged commit 325aa3d into vllm-project:main Aug 22, 2025
48 checks passed
@andyxning andyxning deleted the code_clean branch August 22, 2025 14:39
FFFfff1FFFfff pushed a commit to FFFfff1FFFfff/my_vllm that referenced this pull request Aug 25, 2025
@andyxning @FFFfff1FFFfff
[Misc] local import code clean (vllm-project#23420)
e3ab75c 
Signed-off-by: Andy Xie <[email protected]>
Signed-off-by: FFFfff1FFFfff <[email protected]>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
@andyxning @epwalsh
[Misc] local import code clean (vllm-project#23420)
6faf4b4 
Signed-off-by: Andy Xie <[email protected]>
juuice-lee pushed a commit to juuice-lee/vllm-moe.code that referenced this pull request Aug 28, 2025
@andyxning
[Misc] local import code clean (vllm-project#23420)
4bce11a 
Signed-off-by: Andy Xie <[email protected]>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
@andyxning @amd-xiaoyu12
[Misc] local import code clean (vllm-project#23420)
aaba3b9 
Signed-off-by: Andy Xie <[email protected]>
Signed-off-by: Xiao Yu <[email protected]>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
@andyxning @amd-xiaoyu12
[Misc] local import code clean (vllm-project#23420)
c728670 
Signed-off-by: Andy Xie <[email protected]>
Signed-off-by: Xiao Yu <[email protected]>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
@andyxning @zhewenl
[Misc] local import code clean (vllm-project#23420)
7814c6d 
Signed-off-by: Andy Xie <[email protected]>
dumb0002 pushed a commit to dumb0002/vllm that referenced this pull request Aug 28, 2025
@andyxning @dumb0002
[Misc] local import code clean (vllm-project#23420)
8a4d30c 
Signed-off-by: Andy Xie <[email protected]>
2015aroras pushed a commit to 2015aroras/vllm that referenced this pull request Aug 29, 2025
@andyxning @2015aroras
[Misc] local import code clean (vllm-project#23420)
759ffec 
Signed-off-by: Andy Xie <[email protected]>
mengxingkongzhouhan pushed a commit to mengxingkongzhouhan/vllm that referenced this pull request Aug 30, 2025
@andyxning @mengxingkongzhouhan
[Misc] local import code clean (vllm-project#23420)
55448eb 
Signed-off-by: Andy Xie <[email protected]>
mengxingkongzhouhan pushed a commit to mengxingkongzhouhan/vllm that referenced this pull request Aug 30, 2025
@andyxning @mengxingkongzhouhan
[Misc] local import code clean (vllm-project#23420)
88828a7 
Signed-off-by: Andy Xie <[email protected]>
mengxingkongzhouhan pushed a commit to mengxingkongzhouhan/vllm that referenced this pull request Aug 30, 2025
@andyxning @mengxingkongzhouhan
[Misc] local import code clean (vllm-project#23420)
dffb900 
Signed-off-by: Andy Xie <[email protected]>
mengxingkongzhouhan pushed a commit to mengxingkongzhouhan/vllm that referenced this pull request Aug 30, 2025
@andyxning @mengxingkongzhouhan
[Misc] local import code clean (vllm-project#23420)
6823213 
Signed-off-by: Andy Xie <[email protected]>
mengxingkongzhouhan pushed a commit to mengxingkongzhouhan/vllm that referenced this pull request Aug 30, 2025
@andyxning @mengxingkongzhouhan
[Misc] local import code clean (vllm-project#23420)
9b9abfa 
Signed-off-by: Andy Xie <[email protected]>
nopperl pushed a commit to pfnet/vllm that referenced this pull request Sep 3, 2025
@andyxning @nopperl
[Misc] local import code clean (vllm-project#23420)
7ee6c55 
Signed-off-by: Andy Xie <[email protected]>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Sep 3, 2025
@andyxning @zhewenl
[Misc] local import code clean (vllm-project#23420)
85644a6 
Signed-off-by: Andy Xie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123 zhuohan123 is a code owner

@youkaichao youkaichao Awaiting requested review from youkaichao youkaichao is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyxning @DarkLight1337