-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[CI/Build] Skip Idefics3 and SmolVLM generation test again #23356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/Build] Skip Idefics3 and SmolVLM generation test again #23356
Conversation
Signed-off-by: Isotr0py <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to temporarily disable generation tests for Idefics3
and SmolVLM
by bumping the minimum required transformers
version, due to an issue in recent releases.
The change for Idefics3ForConditionalGeneration
correctly sets min_transformers_version
to 4.56
, which will skip the tests on older versions. However, for SmolVLMForConditionalGeneration
, max_transformers_version
is used instead of min_transformers_version
. This appears to be a mistake, as it will not prevent the tests from running on the problematic 4.55.x
versions. I've added a comment with a suggested fix to align the behavior for both models.
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Isotr0py <[email protected]>
…ect#23356) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: root <[email protected]>
…ect#23356) Signed-off-by: Isotr0py <[email protected]>
…ect#23356) Signed-off-by: Isotr0py <[email protected]>
…ect#23356) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…ect#23356) Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…ect#23356) Signed-off-by: Isotr0py <[email protected]>
…ect#23356) Signed-off-by: Isotr0py <[email protected]>
…ect#23356) Signed-off-by: Isotr0py <[email protected]>
…ect#23356) Signed-off-by: Isotr0py <[email protected]>
…ect#23356) Signed-off-by: Isotr0py <[email protected]>
…ect#23356) Signed-off-by: Isotr0py <[email protected]>
…ect#23356) Signed-off-by: Isotr0py <[email protected]>
…ect#23356) Signed-off-by: Isotr0py <[email protected]>
Purpose
(This really drives me crazy 🤪)
Test Plan
Test Result
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.