-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Bugfix]: Installing dev environment due to pydantic incompatible version #23353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix]: Installing dev environment due to pydantic incompatible version #23353
Conversation
Fix followingerror when installing base dependencies for dev env: we can conclude that openai-harmony>=0.0.3 depends on pydantic>=2.11.7. And because you require openai-harmony>=0.0.3 and pydantic==2.11.5, we can conclude that your requirements are unsatisfiable. Signed-off-by: Martin Hickey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a dependency conflict with pydantic
that arises during the installation of the development environment. The changes update the minimum required version of pydantic
to 2.11.7
in requirements/common.txt
and pin it to the same version in the requirements/test.txt
lockfile. This resolves the incompatibility with the openai-harmony
package and fixes the installation error. The changes are correct and necessary.
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Thanks for fixing! |
@DarkLight1337 Thanks for reviewing. I don't think this PR is breaking CI. |
Retrying the failing tests |
…sion (vllm-project#23353) Signed-off-by: Martin Hickey <[email protected]> Signed-off-by: FFFfff1FFFfff <[email protected]>
…sion (vllm-project#23353) Signed-off-by: Martin Hickey <[email protected]>
…sion (vllm-project#23353) Signed-off-by: Martin Hickey <[email protected]>
…sion (vllm-project#23353) Signed-off-by: Martin Hickey <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…sion (vllm-project#23353) Signed-off-by: Martin Hickey <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…sion (vllm-project#23353) Signed-off-by: Martin Hickey <[email protected]>
…sion (vllm-project#23353) Signed-off-by: Martin Hickey <[email protected]>
…sion (vllm-project#23353) Signed-off-by: Martin Hickey <[email protected]>
Update pydantic version to min
2.11.7
foropenai-harmony
compatibility to fix the following error when installing dev env:Fixes #23352