Skip to content

Conversation

hickeyma
Copy link
Contributor

@hickeyma hickeyma commented Aug 21, 2025

Update pydantic version to min 2.11.7 for openai-harmony compatibility to fix the following error when installing dev env:

$ uv pip install -r requirements/common.txt -r requirements/dev.txt --torch-backend=auto

  × No solution found when resolving dependencies:
  ╰─▶ Because openai-harmony>=0.0.3 depends on pydantic>=2.11.7 and only the following versions of openai-harmony are available:
          openai-harmony<=0.0.3
          openai-harmony==0.0.4
      we can conclude that openai-harmony>=0.0.3 depends on pydantic>=2.11.7.
      And because you require openai-harmony>=0.0.3 and pydantic==2.11.5, we can conclude that your requirements are unsatisfiable.
(vllm) root@marty-gpu-dev-l40s:/data/dev/github.com/vllm-project/vllm# vim requirements/common.txt 
(vllm) root@marty-gpu-dev-l40s:/data/dev/github.com/vllm-project/vllm# vim requirements/common.txt 
(vllm) root@marty-gpu-dev-l40s:/data/dev/github.com/vllm-project/vllm# uv pip install -r requirements/common.txt -r requirements/dev.txt --torch-backend=auto
  × No solution found when resolving dependencies:
  ╰─▶ Because you require pydantic>=2.11.7 and pydantic==2.11.5, we can conclude that your requirements are unsatisfiable.

Fixes #23352

Fix followingerror when installing base dependencies for dev env:

we can conclude that openai-harmony>=0.0.3 depends on pydantic>=2.11.7.
And because you require openai-harmony>=0.0.3 and pydantic==2.11.5,
we can conclude that your requirements are unsatisfiable.

Signed-off-by: Martin Hickey <[email protected]>
@mergify mergify bot added the ci/build label Aug 21, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a dependency conflict with pydantic that arises during the installation of the development environment. The changes update the minimum required version of pydantic to 2.11.7 in requirements/common.txt and pin it to the same version in the requirements/test.txt lockfile. This resolves the incompatibility with the openai-harmony package and fixes the installation error. The changes are correct and necessary.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 21, 2025 16:25
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 21, 2025
@hickeyma
Copy link
Contributor Author

@DarkLight1337 Thanks for reviewing. I don't think this PR is breaking CI.

@DarkLight1337
Copy link
Member

Retrying the failing tests

@DarkLight1337 DarkLight1337 merged commit 613a23b into vllm-project:main Aug 22, 2025
70 checks passed
@hickeyma hickeyma deleted the build/fix-pydantic-version branch August 22, 2025 21:04
FFFfff1FFFfff pushed a commit to FFFfff1FFFfff/my_vllm that referenced this pull request Aug 25, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
juuice-lee pushed a commit to juuice-lee/vllm-moe.code that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
dumb0002 pushed a commit to dumb0002/vllm that referenced this pull request Aug 28, 2025
2015aroras pushed a commit to 2015aroras/vllm that referenced this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Installation]: Failure to install dependencies for dev environment due to incompatible pydantic version
2 participants