-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
[Feature][Responses API] Support logprobs(non-stream) #23319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Responses API] Support logprobs(non-stream) #23319
Conversation
44b8826
to
7479a9b
Compare
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
1ff92d4
to
b1bcf37
Compare
Signed-off-by: Kebe <[email protected]>
b1bcf37
to
4a82547
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution.
BTW I think there are still some todos like logprobs + harmony and streaming, so I change "fix xxx" to "related issue xxx". Can you also help on those parts? |
Glad to do it. |
…3319) Signed-off-by: Kebe <[email protected]> Signed-off-by: root <[email protected]>
…3319) Signed-off-by: Kebe <[email protected]>
…3319) Signed-off-by: Kebe <[email protected]>
…3319) Signed-off-by: Kebe <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…3319) Signed-off-by: Kebe <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…3319) Signed-off-by: Kebe <[email protected]>
…3319) Signed-off-by: Kebe <[email protected]>
@kebe7jun, is non-stream + harmony supported? I saw vllm/vllm/entrypoints/openai/serving_responses.py Lines 210 to 215 in de533ab
|
no, gpt-oss models not support logprobs. |
…3319) Signed-off-by: Kebe <[email protected]>
…3319) Signed-off-by: Kebe <[email protected]>
…3319) Signed-off-by: Kebe <[email protected]>
…3319) Signed-off-by: Kebe <[email protected]>
…3319) Signed-off-by: Kebe <[email protected]>
…3319) Signed-off-by: Kebe <[email protected]>
…3319) Signed-off-by: Kebe <[email protected]>
Related issue #23225
Purpose
Support logprobs for Response API (non-stream).
Stream mode is currently divided into several cases:
gpt-oss
models use Harmony, as they use a custom parser, and logprobs are not implemented yet.gpt-5-mini
also does not support logprobs.Other models have not yet fully implemented the Response Streaming API, so support is temporarily unavailable.
vllm/vllm/entrypoints/openai/serving_responses.py
Lines 795 to 798 in 2e2000f
Test Plan
Added unit tests.
Test Result
See CI.
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.