Skip to content

Conversation

didier-durand
Copy link
Contributor

@didier-durand didier-durand commented Aug 19, 2025

Purpose

Fix typos in multiple files to improve doc quality

Test Plan

N/A

Test Result

N/A

(Optional) Documentation Update

See commit diffs for exact details


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • [N/A ] The test plan, such as providing test command.
  • [N/A ] The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses several typographical errors in comments and documentation across various files. The changes are straightforward and improve the overall readability and quality of the codebase. All fixes are correct and I have no further suggestions as there are no high or critical issues.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@didier-durand didier-durand changed the title doc: fix various typos in multiple files [Doc]: fix various typos in multiple files Aug 19, 2025
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@mgoin mgoin enabled auto-merge (squash) August 19, 2025 20:28
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 19, 2025
@didier-durand
Copy link
Contributor Author

my pleasure!

@vllm-bot vllm-bot merged commit 22cf679 into vllm-project:main Aug 22, 2025
49 of 53 checks passed
@didier-durand
Copy link
Contributor Author

thanks for the merge of this PR!

FFFfff1FFFfff pushed a commit to FFFfff1FFFfff/my_vllm that referenced this pull request Aug 25, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
juuice-lee pushed a commit to juuice-lee/vllm-moe.code that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
dumb0002 pushed a commit to dumb0002/vllm that referenced this pull request Aug 28, 2025
2015aroras pushed a commit to 2015aroras/vllm that referenced this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed structured-output v1
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants