[Misc][gpt-oss] Add rules to label gpt-oss related PRs #22600
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new mergify rule to automatically label pull requests related to gpt-oss. The rule conditions look good for matching PR titles and some file paths. However, the file path matching conditions are a bit too restrictive and might miss some relevant files. For example, a file like vllm/reasoning/gptoss_reasoning_parser.py would not be matched by the current rules. I've suggested a change to make the regex more flexible to catch variations like gpt_oss, gpt-oss, and gptoss, and to make it case-insensitive.
Signed-off-by: Lifan Shen <[email protected]>
draftbk
force-pushed
the
gpt-oss-mergify
branch
from
8fde2b3 to
30c3a8b
Compare
There was a problem hiding this comment.
LGTM, cc @simon-mo @WoosukKwon I have added gpt-oss label to GH already
…22600) Signed-off-by: Lifan Shen <[email protected]> Signed-off-by: jingyu <[email protected]>
…22600) Signed-off-by: Lifan Shen <[email protected]>
…22600) Signed-off-by: Lifan Shen <[email protected]> Signed-off-by: Paul Pak <[email protected]>
…22600) Signed-off-by: Lifan Shen <[email protected]>
…22600) Signed-off-by: Lifan Shen <[email protected]> Signed-off-by: Boyuan Feng <[email protected]>
…22600) Signed-off-by: Lifan Shen <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…22600) Signed-off-by: Lifan Shen <[email protected]>
…22600) Signed-off-by: Lifan Shen <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Add rules to label gpt-oss related PRs
Test Plan
Test Result