-
-
Notifications
You must be signed in to change notification settings - Fork 10k
Add @patrickvonplaten as maintainer of mistral's related files. #21928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @patrickvonplaten as maintainer of mistral's related files. #21928
Conversation
Signed-off-by: Patrick von Platen <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the .github/CODEOWNERS
file to include new entries for Mistral-specific files, assigning ownership to @patrickvonplaten
. The change is straightforward, but I've identified a minor formatting issue with trailing whitespace on two of the new lines. This could potentially affect how the file is parsed, so I've provided a suggestion to correct it.
Signed-off-by: Patrick von Platen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
welcome!
…-project#21928) Signed-off-by: Patrick von Platen <[email protected]>
…-project#21928) Signed-off-by: Patrick von Platen <[email protected]>
…-project#21928) Signed-off-by: Patrick von Platen <[email protected]> Signed-off-by: shuw <[email protected]>
…-project#21928) Signed-off-by: Patrick von Platen <[email protected]> Signed-off-by: shuw <[email protected]>
…-project#21928) Signed-off-by: Patrick von Platen <[email protected]>
…-project#21928) Signed-off-by: Patrick von Platen <[email protected]> Signed-off-by: x22x22 <[email protected]>
…-project#21928) Signed-off-by: Patrick von Platen <[email protected]> Signed-off-by: x22x22 <[email protected]>
…-project#21928) Signed-off-by: Patrick von Platen <[email protected]>
…-project#21928) Signed-off-by: Patrick von Platen <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
…-project#21928) Signed-off-by: Patrick von Platen <[email protected]> Signed-off-by: Noam Gat <[email protected]>
…-project#21928) Signed-off-by: Patrick von Platen <[email protected]> Signed-off-by: Paul Pak <[email protected]>
…-project#21928) Signed-off-by: Patrick von Platen <[email protected]>
…-project#21928) Signed-off-by: Patrick von Platen <[email protected]> Signed-off-by: Boyuan Feng <[email protected]>
…-project#21928) Signed-off-by: Patrick von Platen <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…-project#21928) Signed-off-by: Patrick von Platen <[email protected]>
…-project#21928) Signed-off-by: Patrick von Platen <[email protected]>
…-project#21928) Signed-off-by: Patrick von Platen <[email protected]>
Thanks a bunch for the collaboration @vllm-team!
As discussed offline, I would like to propose myself as one of the maintainers of mistral's current & future models.
Looking forward to next adventures!