-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Hardware][CPU] Build fix for ARM without BF16 #21848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So we can build on older ARM chips like M1 that don't have bf16. Signed-off-by: Eric Curtin <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix a build issue on ARM CPUs that lack BF16 support, like Apple's M1. The change correctly uses a preprocessor directive to conditionally compile a template specialization for c10::BFloat16
. I suggest improving the robustness of this preprocessor condition, making it more maintainable for future architecture additions.
PTAL @mgoin @tlrmchlsmth |
@bigPYJ1151 should I rebase and hope for the best that the build passed? 😅 |
@ericcurtin It's not worth to re-run all tests. I'll request for force merge. |
Signed-off-by: Eric Curtin <[email protected]>
Signed-off-by: Eric Curtin <[email protected]>
Signed-off-by: Eric Curtin <[email protected]> Signed-off-by: shuw <[email protected]>
Signed-off-by: Eric Curtin <[email protected]> Signed-off-by: shuw <[email protected]>
Signed-off-by: Eric Curtin <[email protected]>
Signed-off-by: Eric Curtin <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: Eric Curtin <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: Eric Curtin <[email protected]>
Signed-off-by: Eric Curtin <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: Eric Curtin <[email protected]> Signed-off-by: Noam Gat <[email protected]>
Signed-off-by: Eric Curtin <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: Eric Curtin <[email protected]>
Signed-off-by: Eric Curtin <[email protected]> Signed-off-by: Boyuan Feng <[email protected]>
Signed-off-by: Eric Curtin <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
So we can build on older ARM chips like M1 that don't have bf16.