Skip to content

[Hardware][CPU] Build fix for ARM without BF16 #21848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025

Conversation

ericcurtin
Copy link
Contributor

@ericcurtin ericcurtin commented Jul 29, 2025

So we can build on older ARM chips like M1 that don't have bf16.

So we can build on older ARM chips like M1 that don't have bf16.

Signed-off-by: Eric Curtin <[email protected]>
@ericcurtin ericcurtin requested a review from bigPYJ1151 as a code owner July 29, 2025 15:47
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix a build issue on ARM CPUs that lack BF16 support, like Apple's M1. The change correctly uses a preprocessor directive to conditionally compile a template specialization for c10::BFloat16. I suggest improving the robustness of this preprocessor condition, making it more maintainable for future architecture additions.

@ericcurtin
Copy link
Contributor Author

PTAL @mgoin @tlrmchlsmth

@ericcurtin
Copy link
Contributor Author

@simon-mo @dtrifiro PTAL

@bigPYJ1151 bigPYJ1151 enabled auto-merge (squash) July 30, 2025 10:00
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 30, 2025
@ericcurtin
Copy link
Contributor Author

@bigPYJ1151 should I rebase and hope for the best that the build passed? 😅

@bigPYJ1151
Copy link
Member

@bigPYJ1151 should I rebase and hope for the best that the build passed? 😅

@ericcurtin It's not worth to re-run all tests. I'll request for force merge.

@vllm-bot vllm-bot merged commit b876860 into vllm-project:main Jul 30, 2025
109 of 111 checks passed
@ericcurtin ericcurtin deleted the fix-ARM_WO_BF16 branch July 30, 2025 13:36
@skmkt skmkt mentioned this pull request Jul 31, 2025
1 task
liuyumoye pushed a commit to liuyumoye/vllm that referenced this pull request Jul 31, 2025
juuice-lee pushed a commit to juuice-lee/vllm-moe.code that referenced this pull request Jul 31, 2025
wenscarl pushed a commit to wenscarl/vllm that referenced this pull request Aug 4, 2025
wenscarl pushed a commit to wenscarl/vllm that referenced this pull request Aug 4, 2025
vadiklyutiy pushed a commit to CentML/vllm that referenced this pull request Aug 5, 2025
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
taneem-ibrahim pushed a commit to taneem-ibrahim/vllm that referenced this pull request Aug 14, 2025
BoyuanFeng pushed a commit to BoyuanFeng/vllm that referenced this pull request Aug 14, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants