Skip to content

Conversation

bringlein
Copy link
Contributor

@bringlein bringlein commented Jul 25, 2025

Purpose

Enable triton 3.3 (which actually ships with pytorch 2.7) on rocm-builds. Triton 3.3. generally brings performance improvements.

CC: @SageMoore

Test Plan

CI?

Test Result

N/A

(Optional) Documentation Update

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added ci/build rocm Related to AMD ROCm labels Jul 25, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Triton dependency for ROCm builds from version 3.2 to 3.3.0. The change is straightforward and aligns with the goal of enabling Triton 3.3, which is compatible with PyTorch 2.7.0 as listed in the same requirements file. The new version specifier is explicit and pinned, which is a best practice for ensuring reproducible builds. The change appears correct and self-contained.

Copy link
Contributor

@SageMoore SageMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Unfortunately, AFAIK, this build path isn't covered in CI. To test changes to this file I usually just run pip install -r requirements/rocm-build.txt --no-cache-dir to make sure everything works.

@bringlein
Copy link
Contributor Author

Looks like this works:

uv pip install -r requirements/rocm-build.txt --no-cache-dir --index-strategy unsafe-best-match
Resolved 123 packages in 1.38s
Prepared 123 packages in 1m 29s
░░░░░░░░░░░░░░░░░░░░ [0/123] Installing wheels...                                                                                                                                                                                                                                                                                                                         
Installed 123 packages in 9.73s

@ProExpertProg ProExpertProg enabled auto-merge (squash) August 22, 2025 14:38
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 22, 2025
@ProExpertProg ProExpertProg merged commit 51a2153 into vllm-project:main Aug 22, 2025
23 of 24 checks passed
FFFfff1FFFfff pushed a commit to FFFfff1FFFfff/my_vllm that referenced this pull request Aug 25, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
juuice-lee pushed a commit to juuice-lee/vllm-moe.code that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
dumb0002 pushed a commit to dumb0002/vllm that referenced this pull request Aug 28, 2025
2015aroras pushed a commit to 2015aroras/vllm that referenced this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants