-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Fix] Bump triton version in rocm-build requirements #21630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Burkhard Ringlein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Triton dependency for ROCm builds from version 3.2 to 3.3.0. The change is straightforward and aligns with the goal of enabling Triton 3.3, which is compatible with PyTorch 2.7.0 as listed in the same requirements file. The new version specifier is explicit and pinned, which is a best practice for ensuring reproducible builds. The change appears correct and self-contained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Unfortunately, AFAIK, this build path isn't covered in CI. To test changes to this file I usually just run pip install -r requirements/rocm-build.txt --no-cache-dir
to make sure everything works.
Looks like this works:
|
) Signed-off-by: Burkhard Ringlein <[email protected]> Signed-off-by: FFFfff1FFFfff <[email protected]>
) Signed-off-by: Burkhard Ringlein <[email protected]>
) Signed-off-by: Burkhard Ringlein <[email protected]>
) Signed-off-by: Burkhard Ringlein <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
) Signed-off-by: Burkhard Ringlein <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
) Signed-off-by: Burkhard Ringlein <[email protected]>
) Signed-off-by: Burkhard Ringlein <[email protected]>
) Signed-off-by: Burkhard Ringlein <[email protected]>
Purpose
Enable triton 3.3 (which actually ships with pytorch 2.7) on rocm-builds. Triton 3.3. generally brings performance improvements.
CC: @SageMoore
Test Plan
CI?
Test Result
N/A
(Optional) Documentation Update