-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Bugfix] Fix casing warning #21468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix casing warning #21468
Conversation
Signed-off-by: Matthew Bonanni <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a FromAsCasing
warning in the docker/Dockerfile
by capitalizing the as
keyword to AS
in the FROM
instruction. This change aligns with Dockerfile best practices for instruction casing and successfully resolves the build warning as intended. The change is straightforward and looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the find!
Signed-off-by: Matthew Bonanni <[email protected]> Signed-off-by: 董巍 <[email protected]>
Signed-off-by: Matthew Bonanni <[email protected]> Signed-off-by: 董巍 <[email protected]>
Signed-off-by: Matthew Bonanni <[email protected]> Signed-off-by: avigny <[email protected]>
Signed-off-by: Matthew Bonanni <[email protected]> Signed-off-by: shuw <[email protected]>
Signed-off-by: Matthew Bonanni <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: Matthew Bonanni <[email protected]>
Signed-off-by: Matthew Bonanni <[email protected]>
Signed-off-by: Matthew Bonanni <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: Matthew Bonanni <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: Matthew Bonanni <[email protected]>
Signed-off-by: Matthew Bonanni <[email protected]> Signed-off-by: Boyuan Feng <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Fix FromAsCasing warning in docker build
Test Plan
DOCKER_BUILDKIT=1 docker build . --target vllm-openai --tag vllm/vllm-openai --file docker/Dockerfile
Test Result
Previously:
=> WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 268) 0.0s
Now, no warning.
(Optional) Documentation Update