-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[Tests] Add tests for headless internal DP LB #21450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nick Hill <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds important tests for the headless internal data-parallel load balancer, which was a notable gap. The refactoring of Prometheus-based verification logic into test_utils.py
is a great move for code reuse and maintainability.
The new tests in test_internal_lb_dp.py
are comprehensive. My primary feedback is to replace the time.sleep()
calls used for server synchronization with a more robust polling mechanism. This will prevent potential flakiness in the CI pipeline, which is critical for test stability.
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: qizixi <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: avigny <[email protected]>
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: shuw <[email protected]>
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
This was a gap in our DP tests.
Includes moving some common prometheus-based load-balancing verification to
test_utils.py
.