-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[Docs] Clean up v1/metrics.md #21449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides a nice cleanup of the metrics.md
design document, improving grammar, style consistency, and link formatting. The changes enhance readability. I've identified one issue with markdown formatting where paragraphs under list items are indented with 4 spaces, which would incorrectly render them as code blocks. I've suggested changing this to a 2-space indent to ensure correct rendering as paragraphs.
Signed-off-by: windsonsea <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this cleanup!
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: windsonsea <[email protected]> Signed-off-by: qizixi <[email protected]>
Signed-off-by: windsonsea <[email protected]>
Signed-off-by: windsonsea <[email protected]> Signed-off-by: avigny <[email protected]>
Signed-off-by: windsonsea <[email protected]> Signed-off-by: shuw <[email protected]>
Signed-off-by: windsonsea <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: windsonsea <[email protected]>
Signed-off-by: windsonsea <[email protected]>
Performed these minor actions:
No any meaning changed.