-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[Bugfix] Fix nightly transformers CI failure #21427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix nightly transformers CI failure #21427
Conversation
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily addresses a nightly CI failure by disabling a problematic model test and removing a deprecated function call from the transformers
library. Additionally, it introduces a new model configuration for Nemotron_Nano_VL
. The changes are logical and well-contained. I have one suggestion to improve error handling in the newly added configuration file to make it more robust.
"mistralai/Voxtral-Mini-3B-2507", | ||
min_transformers_version="4.54", | ||
# disable this temporarily until we support HF format | ||
is_available_online=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HF format Voxtral hasn't been supported now, so I disabled it here and will add support in a following PR.
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: qizixi <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: avigny <[email protected]>
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: shuw <[email protected]>
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Test Plan
Test Result
(Optional) Documentation Update