[CI/Build] Fix test failure due to updated model repo #21375
Conversation
Signed-off-by: DarkLight1337 <[email protected]>
DarkLight1337
added
the
ready
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to fix a test failure by updating the model registry to specify a minimum transformers version for ERNIE models. The change correctly identifies the need for a newer transformers version. However, it incorrectly removes the trust_remote_code=True flag, which is still required for these models as they contain custom code. I've suggested a fix to re-introduce this flag to ensure the models can be loaded correctly.
|
Will force-merge once basic models tests pass |
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
…1375) Signed-off-by: DarkLight1337 <[email protected]>
…1375) Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: qizixi <[email protected]>
…1375) Signed-off-by: DarkLight1337 <[email protected]>
…1375) Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: avigny <[email protected]>
…1375) Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: shuw <[email protected]>
…1375) Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: x22x22 <[email protected]>
…1375) Signed-off-by: DarkLight1337 <[email protected]>
…1375) Signed-off-by: DarkLight1337 <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Fix failing model tests due to ERNIE model repo being updated to transformers v4.54, e.g.: https://huggingface.co/baidu/ERNIE-4.5-0.3B-PT/commit/54cd03c1f4dc38d601910726156d4b685c4fd6d6#d2h-025836
Test Plan
Test Result
(Optional) Documentation Update