-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[Intel GPU] Ray Compiled Graph avoid NCCL for Intel GPU #21338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ratnampa <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly identifies and fixes a runtime failure for Intel GPUs when using Ray's compiled DAG by forcing the communication channel to 'shm'. I've suggested extending this fix to also include ROCm platforms, as they would likely suffer from the same issue, making the solution more robust.
# For TPU or XPU, avoid compiling NVIDIA's NCCL | ||
if current_platform.is_tpu() or current_platform.is_xpu(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix! Your reasoning that Ray's compiled DAG defaults to NCCL for any GPU is spot on.
Following this logic, it seems that ROCm (AMD GPUs) would also face the same runtime failure. To make this fix more comprehensive and prevent issues on ROCm, I suggest including it in the condition. This would also align with how XPU and ROCm are often handled together elsewhere in the codebase.
I've also updated the comment to reflect this.
# For TPU or XPU, avoid compiling NVIDIA's NCCL | |
if current_platform.is_tpu() or current_platform.is_xpu(): | |
# For TPU, XPU, or ROCm, avoid compiling NVIDIA's NCCL | |
if current_platform.is_tpu() or current_platform.is_xpu() or current_platform.is_rocm(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not working with the AMD GPUs, so won't be able to test and make the requested changes.
@DarkLight1337 can I please get a review for this? |
…#21338) Signed-off-by: ratnampa <[email protected]> Signed-off-by: qizixi <[email protected]>
…#21338) Signed-off-by: ratnampa <[email protected]>
…#21338) Signed-off-by: ratnampa <[email protected]> Signed-off-by: avigny <[email protected]>
…#21338) Signed-off-by: ratnampa <[email protected]> Signed-off-by: shuw <[email protected]>
…#21338) Signed-off-by: ratnampa <[email protected]> Signed-off-by: x22x22 <[email protected]>
…#21338) Signed-off-by: ratnampa <[email protected]>
…#21338) Signed-off-by: ratnampa <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Ray compiled DAG causes runtime failure for PP+TP setup with XPU (Intel GPU). This is due to with_tensor_transport set to auto and further ray resolves this to NCCL as XPU device is a GPU, but inside ray compiled dag GPU-to-GPU transfers are only yet supported for NCCL NV GPUs. Setting to "shm" resolves the issue.
Test Plan
Test Result
(Optional) Documentation Update