Skip to content

Update fp4 quantize API #21327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged

Conversation

wenscarl
Copy link
Contributor

@wenscarl wenscarl commented Jul 21, 2025

Update fp4 quantize API

cc. @alexm-redhat

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Test Plan

Test Result

(Optional) Documentation Update

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the FlashInfer FP4 quantization API by renaming fp4_swizzle_blockscale to nvfp4_block_scale_interleave and updating a function call in flashinfer_cutlass_moe to use keyword arguments. The code changes are consistent across the modified files and improve readability. A significant concern is the absence of tests to validate these changes. Modifying low-level quantization kernels without corresponding tests introduces a high risk of regressions. It is highly recommended to add unit or integration tests that specifically exercise the FP4 MoE functionality with the updated FlashInfer API to ensure the integration is correct and robust.

@wenscarl wenscarl force-pushed the flashinfer_fp4_update branch 2 times, most recently from 27567c7 to 5d52dc4 Compare July 21, 2025 20:15
@wenscarl wenscarl marked this pull request as ready for review July 21, 2025 20:15
Copy link
Collaborator

@alexm-redhat alexm-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix!

@alexm-redhat alexm-redhat enabled auto-merge (squash) July 21, 2025 20:45
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 21, 2025
Signed-off-by: Shu Wang <[email protected]>
auto-merge was automatically disabled July 21, 2025 20:57

Head branch was pushed to by a user without write access

@wenscarl wenscarl force-pushed the flashinfer_fp4_update branch from 5d52dc4 to 44bb0cf Compare July 21, 2025 20:57
@vllm-bot vllm-bot merged commit 9e23ad9 into vllm-project:main Jul 22, 2025
66 of 68 checks passed
yeqcharlotte pushed a commit to yeqcharlotte/vllm that referenced this pull request Jul 23, 2025
zixi-qi pushed a commit to zixi-qi/vllm that referenced this pull request Jul 23, 2025
LyrisZhong pushed a commit to LyrisZhong/vllm that referenced this pull request Jul 23, 2025
avigny pushed a commit to avigny/vllm that referenced this pull request Jul 31, 2025
wenscarl added a commit to wenscarl/vllm that referenced this pull request Aug 4, 2025
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants