[Cleanup] Only log MoE DP setup warning if DP is enabled #21315
Conversation
Signed-off-by: mgoin <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a small but useful cleanup in the Fused MoE configuration. The change ensures that a warning about MoE Data Parallelism (DP) setup is only logged when DP is actually enabled (dp_size > 1). This prevents unnecessary warnings and reduces log noise when DP is not in use. The implementation is correct and straightforward. I have no further comments.
github-actions
bot
added
the
ready
…t#21315) Signed-off-by: mgoin <[email protected]> Signed-off-by: qizixi <[email protected]>
…t#21315) Signed-off-by: mgoin <[email protected]>
…t#21315) Signed-off-by: mgoin <[email protected]> Signed-off-by: avigny <[email protected]>
…t#21315) Signed-off-by: mgoin <[email protected]> Signed-off-by: shuw <[email protected]>
…t#21315) Signed-off-by: mgoin <[email protected]> Signed-off-by: x22x22 <[email protected]>
…t#21315) Signed-off-by: mgoin <[email protected]>
…t#21315) Signed-off-by: mgoin <[email protected]>
Purpose
Before this change, any deployment of an MoE kernel that isn't setup to use DP would print a warning about this even if DP wasn't being used at all. I just want to restrict this to only trigger if DP is used.
Test Plan
Test Result