[V0 deprecation] Remove V0 HPU backend #21131
Conversation
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
WoosukKwon
requested review from
jeejeelee,
zhuohan123,
youkaichao,
alexm-redhat,
comaniac and
njhill
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Woosuk Kwon <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively removes the V0 HPU backend, which is a significant and welcome cleanup. The changes are mostly removals of HPU-specific files and code paths, and they appear to be correct and self-contained.
I've identified one piece of dead code that was left behind in setup.py and have commented on it directly.
Additionally, my review of the entire codebase (not just the changed files) revealed a few other HPU-related leftovers that were not part of this pull request's diff. Since I cannot comment on files that were not modified, I'm listing them here for your consideration in a follow-up PR:
- In
vllm/config.py, theDevicetype hint still includes"hpu". - In
vllm/envs.py, HPU-specific environment variables likeVLLM_USE_HPU_CONTIGUOUS_CACHE_FETCHandVLLM_HPU_USE_DELAYED_SAMPLINGare still defined.
Addressing these will complete the removal of the HPU backend. Overall, great work on this large-scale refactoring!
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
WoosukKwon
requested review from
simon-mo,
robertgshaw2-redhat,
mgoin,
tlrmchlsmth,
houseroad and
hmellor
as code owners
|
Please make corresponding update to docs. |
Signed-off-by: Woosuk Kwon <[email protected]>
|
@kzawora-intel , please take a look. |
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: WorldExplored <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: Himanshu Jaju <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: avigny <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
In vLLM V1, HPU is supported as a plugin.