Fix inadvertently silenced PP tests for mp, add DeepSeek V2/V3 model family to PP tests
#20831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @eicherseiji, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing the test suite's coverage by integrating the DeepSeek V2/V3 model family into the existing pipeline parallel tests. This ensures that the system's compatibility and performance with these new models are validated, contributing to a more robust and comprehensive testing framework.
Highlights
- Test Coverage Expansion: I've expanded the pipeline parallel test coverage to include the DeepSeek V2/V3 model family. This was achieved by adding
deepseek-ai/DeepSeek-V2-Lite-Chatto the list of models used in the existingtest_pipeline_parallel.pysuite.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds deepseek-ai/DeepSeek-V2-Lite-Chat to the pipeline parallelism tests, increasing test coverage for the DeepSeek model family. My review focuses on ensuring the changes align with the stated goals of the PR. I've pointed out that while the PR aims to add coverage for both DeepSeek V2 and V3, only a V2 model has been included. I've recommended adding a V3 model to fully address the PR's objective.
ruisearch42
reviewed
Jul 11, 2025
| @@ -248,6 +248,7 @@ def iter_params(self, model_id: str): | |||
| "meta-llama/Llama-3.2-1B-Instruct", | |||
| "ArthurZ/Ilama-3.2-1B", | |||
| "ibm/PowerLM-3b", | |||
| "deepseek-ai/DeepSeek-V2-Lite-Chat", | |||
There was a problem hiding this comment.
by default L4 is used which cannot hold this model. You need to change gpu to a100 (that's the only other option) in test-pipeline.yaml.
@simon-mo @youkaichao considering the popularity of deepseek + PP, maybe it's worth adding this test with a100?
There was a problem hiding this comment.
btw, I recall A100 does not support a specific fp8 format that vanilla DeepSeekV3 requires when I tested it (not sure about DeepSeekV2), so A100 might not be enough (Hopper for sure works)
There was a problem hiding this comment.
Need to check if the exact configuration in this test_pipeline_parallel.py will work, but sanity check on Anyscale was successful for this model:
|
OOM but test passes. Following up to fix. |
|
The PP run was successful, but the baseline (defaults to TP=1, PP=1) failed with OOM (ofc). Seems like #14219 inadvertently silenced all |
ruisearch42
reviewed
Jul 14, 2025
|
Additional test failure surfaced after test bugfix: https://buildkite.com/vllm/ci/builds/23938#01980b35-a0f5-41c8-b364-731727cca107 |
|
TPU test failures due to:
Distributed test failure due to: These don't seem related to the test addition/fix. |
Signed-off-by: Seiji Eicher <[email protected]>
Signed-off-by: Seiji Eicher <[email protected]>
Signed-off-by: Seiji Eicher <[email protected]>
Signed-off-by: Seiji Eicher <[email protected]>
eicherseiji
force-pushed
the
test-deepseek-v2-pp
branch
from
80600bb to
480beba
Compare
Signed-off-by: Seiji Eicher <[email protected]>
|
Looks like #20771 changed resolution of Since |
eicherseiji
commented
Jul 15, 2025
| "intfloat/e5-mistral-7b-instruct": PPTestSettings.fast(), | ||
| "BAAI/bge-multilingual-gemma2": PPTestSettings.fast(), | ||
| "Qwen/Qwen2.5-Math-RM-72B": PPTestSettings.fast(load_format="dummy"), | ||
| "intfloat/e5-mistral-7b-instruct": PPTestSettings.fast(task="embed"), |
There was a problem hiding this comment.
Needed due to #20771
eicherseiji
commented
Jul 15, 2025
|
|
||
| dtype = "float16" | ||
| if hf_config.model_type in _FLOAT16_NOT_SUPPORTED_MODELS: | ||
| dtype = "bfloat16" |
There was a problem hiding this comment.
Needed since BAAI/bge-multilingual-gemma2 doesn't support float16
|
TPU v1 test also failing on @ruisearch42 can you take a look when you get a chance? A few additional test fixes were needed to recover since the test was disabled. Thanks for your help so far! |
eicherseiji
changed the title
mp were disabled, add DeepSeek V2/V3 model family to PP tests
eicherseiji
changed the title
mp were disabled, add DeepSeek V2/V3 model family to PP testsmp, add DeepSeek V2/V3 model family to PP tests
DarkLight1337
approved these changes
Jul 16, 2025
nadathurv
pushed a commit
to nadathurv/vllm
that referenced
this pull request
Jul 16, 2025
…l family to PP tests (vllm-project#20831) Signed-off-by: Seiji Eicher <[email protected]>
hj-mistral
pushed a commit
to hj-mistral/vllm
that referenced
this pull request
Jul 19, 2025
…l family to PP tests (vllm-project#20831) Signed-off-by: Seiji Eicher <[email protected]> Signed-off-by: Himanshu Jaju <[email protected]>
LyrisZhong
pushed a commit
to LyrisZhong/vllm
that referenced
this pull request
Jul 23, 2025
…l family to PP tests (vllm-project#20831) Signed-off-by: Seiji Eicher <[email protected]>
avigny
pushed a commit
to avigny/vllm
that referenced
this pull request
Jul 31, 2025
…l family to PP tests (vllm-project#20831) Signed-off-by: Seiji Eicher <[email protected]> Signed-off-by: avigny <[email protected]>
x22x22
pushed a commit
to x22x22/vllm
that referenced
this pull request
Aug 5, 2025
…l family to PP tests (vllm-project#20831) Signed-off-by: Seiji Eicher <[email protected]> Signed-off-by: x22x22 <[email protected]>
Pradyun92
pushed a commit
to Pradyun92/vllm
that referenced
this pull request
Aug 6, 2025
…l family to PP tests (vllm-project#20831) Signed-off-by: Seiji Eicher <[email protected]>
npanpaliya
pushed a commit
to odh-on-pz/vllm-upstream
that referenced
this pull request
Aug 6, 2025
…l family to PP tests (vllm-project#20831) Signed-off-by: Seiji Eicher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Test Plan
Add parameter to existing test:
tests/distributed/test_pipeline_parallel.py.Test Result
N/A, test passes
(Optional) Documentation Update