-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[Misc] improve error msg #20604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] improve error msg #20604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @reidliu41, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the user experience for data parallel configuration within the CLI. My aim is to make the system more intuitive by providing clearer guidance through enhanced error messages and more informative help text, thereby reducing common configuration mistakes and debugging time for users.
Highlights
- Improved Error Message: I've enhanced the
ValueError
message fordata_parallel_start_rank
when used without--headless
. The new message now explicitly advises users to 'Add --headless flag to enable headless mode.', making it more actionable and user-friendly. - Enhanced Help Text: I've updated the help text for the
--data-parallel-start-rank
(-dpr
) command-line argument. It now clearly states that this parameter 'Requires --headless', providing crucial information upfront to prevent configuration errors.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves the user experience for data parallel configuration by enhancing a help text and an error message. The changes are clear and achieve the stated goal. I've identified a minor formatting issue in the new error message that results in a double space and have suggested a fix to improve the code's correctness and maintainability.
vllm/entrypoints/cli/serve.py
Outdated
"data_parallel_start_rank is only applicable " | ||
" in headless mode. " | ||
"Add --headless flag to enable headless mode.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implicit string concatenation here introduces an extra space in the error message before 'in headless mode.'. This can be fixed by removing the leading space in the second part of the string. This improves the correctness of the user-facing message and the maintainability of the code.
"data_parallel_start_rank is only applicable " | |
" in headless mode. " | |
"Add --headless flag to enable headless mode.") | |
"data_parallel_start_rank is only applicable " | |
"in headless mode. " | |
"Add --headless flag to enable headless mode.") |
Signed-off-by: reidliu41 <[email protected]>
1a6afe3
to
4a81842
Compare
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: reidliu41 <[email protected]>
Signed-off-by: reidliu41 <[email protected]>
Signed-off-by: reidliu41 <[email protected]> Signed-off-by: Patrick von Platen <[email protected]>
Signed-off-by: reidliu41 <[email protected]>
Signed-off-by: reidliu41 <[email protected]> Signed-off-by: avigny <[email protected]>
Signed-off-by: reidliu41 <[email protected]>
Signed-off-by: reidliu41 <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
improves the user experience for data parallel configuration by enhancing help text
and error messages. Users will now understand parameter requirements before encountering
errors, reducing configuration mistakes and debugging time.
Test Plan
Test Result
(Optional) Documentation Update