[Benchmark] Add support for multiple batch size benchmark through CLI in benchmark_moe.py + Add Triton Fused MoE kernel config for FP8 E=16 on B200
#20516
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Brayden Zhong <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @b8zhong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the benchmark_moe.py script by allowing users to specify multiple batch sizes for benchmarking in a single run. This is achieved by modifying the argument parser to accept a list of batch sizes and updating the code to iterate over these batch sizes during the benchmarking process. This change improves the flexibility and efficiency of the benchmarking script.
Highlights
- Argparse Modification: Modified the argparse configuration to accept multiple batch sizes as input via the command line using
nargs="+". - Batch Size Handling: Updated the code to handle a list of batch sizes instead of a single batch size when the user provides multiple values through the
--batch-sizeargument.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly adds support for benchmarking multiple batch sizes in a single run by updating the --batch-size command-line argument to accept multiple values. The implementation is sound. I've added one suggestion to improve the clarity of the new command-line argument to enhance maintainability and prevent potential confusion.
Signed-off-by: Brayden Zhong <[email protected]>
github-actions
bot
added
the
ready
b8zhong
changed the title
benchmark_moe.pybenchmark_moe.py + Add Triton Fused MoE kernel config for FP8 E=16 on B200
… in `benchmark_moe.py` (vllm-project#20516) Signed-off-by: Brayden Zhong <[email protected]>
… in `benchmark_moe.py` (vllm-project#20516) Signed-off-by: Brayden Zhong <[email protected]>
… in `benchmark_moe.py` (vllm-project#20516) Signed-off-by: Brayden Zhong <[email protected]> Signed-off-by: Patrick von Platen <[email protected]>
… in `benchmark_moe.py` (vllm-project#20516) Signed-off-by: Brayden Zhong <[email protected]>
… in `benchmark_moe.py` (vllm-project#20516) Signed-off-by: Brayden Zhong <[email protected]> Signed-off-by: avigny <[email protected]>
… in `benchmark_moe.py` (vllm-project#20516) Signed-off-by: Brayden Zhong <[email protected]>
… in `benchmark_moe.py` (vllm-project#20516) Signed-off-by: Brayden Zhong <[email protected]>
Purpose
Add support for specifying multiple batch sizes via
--batch-sizeinbenchmark_moe.py.Test Plan
nargs="+"for batch size.--batch-size 128 256 512.Also add tuned fused MoE for
RedHatAI/Llama-4-Scout-17B-16E-Instruct-FP8-dynamicfor B200Test Result
Confirmed successful tuning for multiple batch sizes in a single run. Config files generated correctly