[Bugfix] fix quark ptpc

[lihaoyang-amd]

This is a fix for importing the quark ptpc quantization format.

[gemini-code-assist]

Summary of Changes

Hello @lihaoyang-amd, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue in the Quark quantization implementation, specifically in the QuarkW8A8Fp8 scheme. It ensures that the quantization parameters are correctly initialized and that the appropriate quantization scheme is used during weight processing. Additionally, it handles the case where per-token quantization is needed for dynamic inputs.

Highlights

• Bugfix: Corrects the initialization of QuarkW8A8Fp8 by passing the weight and input configurations directly, instead of extracting individual parameters.
• Quantization Scheme: Ensures the correct quantization scheme (per_tensor or per_channel) is used when processing weights and creating weight scales.
• Dynamic Input Handling: Adds logic to handle per-token quantization when the input is dynamic and the input quantization scheme is per-channel.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a bugfix for Quark FP8 quantization, specifically enabling support for dynamic per-token quantization which was previously not handled correctly. The changes are well-structured, refactoring the QuarkW8A8Fp8 scheme to correctly interpret quantization configurations and propagate the necessary flags to the linear operator. The code is clearer and more robust as a result.

[github-actions]

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

[mgoin]

This seems reasonable, thanks. Is there a test in CI to exercise this code?

[lihaoyang-amd]

This seems reasonable, thanks. Is there a test in CI to exercise this code?

@mgoin
Hi, Mr. Goin, I did some E2E experiments and the code is fine.
Now that the pr has been merged, I will add the ptpc ci in the next pr by the way.
Thank you.