use .dev for version comparison with pytorch nightly release #20031
Conversation
BoyuanFeng
requested review from
mgoin,
robertgshaw2-redhat and
tlrmchlsmth
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @BoyuanFeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a version comparison discrepancy between local PyTorch builds and PyTorch nightly releases. By updating the expected version string from '2.8.0a' to '2.8.0.dev', it ensures that vLLM's features dependent on specific PyTorch versions, particularly those requiring standalone compilation, are correctly activated in environments using PyTorch nightly builds.
Highlights
- PyTorch Version Compatibility: Updated version comparison strings from '2.8.0a' to '2.8.0.dev' to correctly identify PyTorch nightly releases. This addresses an issue where local PyTorch builds might use '2.8.0a' while nightly releases use '2.8.0.dev', causing version checks to fail in CI.
- Enabling Standalone Compile: Ensured that features relying on
standalone_compile, such asInductorStandaloneAdaptorand TorchAO quantization, are correctly enabled when running with PyTorch nightly builds by adjusting the version check.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Signed-off-by: Boyuan Feng <[email protected]>
BoyuanFeng
force-pushed
the
bf/torch-dev-version
branch
from
1c023f5 to
1beb32b
Compare
There was a problem hiding this comment.
Code Review
The pull request modifies version checks in vllm/compilation/backends.py and vllm/model_executor/layers/quantization/torchao.py to use 2.8.0.dev instead of 2.8.0a for enabling standalone compile in vllm x torch nightly CI tests. The changes aim to address inconsistencies between local PyTorch builds and nightly releases. The review focuses on ensuring that these version updates do not introduce unintended side effects or regressions in other parts of the codebase.
| if envs.VLLM_USE_STANDALONE_COMPILE and is_torch_equal_or_newer( | ||
| "2.8.0a"): | ||
| "2.8.0.dev"): |
There was a problem hiding this comment.
Changing the version check to 2.8.0.dev from 2.8.0a seems reasonable given the PR description. This ensures compatibility with PyTorch nightly releases. However, ensure that this change doesn't inadvertently affect other version-dependent logic that might rely on the 2.8.0a check.
"2.8.0.dev"):
Signed-off-by: Boyuan Feng <[email protected]>
…oject#20031) Signed-off-by: Boyuan Feng <[email protected]>
…oject#20031) Signed-off-by: Boyuan Feng <[email protected]>
…oject#20031) Signed-off-by: Boyuan Feng <[email protected]> Signed-off-by: Will Eaton <[email protected]>
…oject#20031) Signed-off-by: Boyuan Feng <[email protected]>
…oject#20031) Signed-off-by: Boyuan Feng <[email protected]>
…oject#20031) Signed-off-by: Boyuan Feng <[email protected]> Signed-off-by: avigny <[email protected]>
#19587 tried to use
2.8.0.afor enabling standalone_compile in vllm x torch nightly CI tests.There is an issue that local pytorch build gives
2.8.0.a, but pytorch nightly release gives2.8.0.dev. To save build time the ci tests uses pytorch nightly release instead of local pytorch build. Since2.8.0.dev<2.8.0.a, this pr uses.devinstead.