Revert "Fix(models/siglip): Add compatibility for Gemma models quantized by llm-compressor" #20030
Conversation
…zed by l…" This reverts commit 493c275.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Isotr0py, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've submitted this pull request to revert a previous change that inadvertently introduced a regression, specifically preventing the successful loading of unquantized Gemma3 models. The primary goal is to restore stability and functionality for these models while a more robust and compatible solution for quantized models is developed and submitted.
Highlights
- Reversion of Previous Change: This pull request fully reverts the changes introduced in
vllm-project/vllm#19643. - Gemma3 Model Compatibility Fix: The reversion specifically addresses a reported issue where the previous change (
#19643) broke the loading of unquantized Gemma3 models. This PR restores compatibility for these models. - Tensor Mapping Adjustment: The core change involves removing a specific tensor mapping entry (
"vision_tower.vision_model.": "vision_model."fromvllm/model_executor/models/gemma3_mm.py) that was causing the regression.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change that added compatibility for Gemma models quantized by llm-compressor. The reversion aims to address a reported issue where the original change broke unquantized Gemma3 models loading. The review focuses on ensuring the reverted code maintains the project's overall functionality and stability.
| }) | ||
|
|
There was a problem hiding this comment.
This line was removed as part of reverting the pull request. Ensure that the removal does not negatively impact the functionality of the code, especially concerning vision tower processing.
|
Hi @Isotr0py , Thank you for the heads-up and for maintaining the stability of the main branch. I sincerely apologize that my initial fix caused a regression for unquantized Gemma3 models. I understand the issue now. My previous fix was not specific enough and affected other model-loading paths. I will start working on a proper solution immediately. My plan is to create a more targeted fix on a new branch that handles the quantized VLM case without impacting the standard text model loading. I will ensure it's thoroughly verified before submitting a new Pull Request. I appreciate your trust and will keep you updated. |
…zed by llm-compressor" (vllm-project#20030)
…zed by llm-compressor" (vllm-project#20030)
…zed by llm-compressor" (vllm-project#20030) Signed-off-by: Will Eaton <[email protected]>
…zed by llm-compressor" (vllm-project#20030)
…zed by llm-compressor" (vllm-project#20030)
…zed by llm-compressor" (vllm-project#20030) Signed-off-by: avigny <[email protected]>
Reverts #19643