-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
Update test case parameter to have the throughput above 8.0 #19994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Qiliang Cui <[email protected]>
@yaochengji could you help to review this small change? |
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @QiliangCui, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the configuration for a specific test case to ensure it consistently meets a target throughput requirement. The adjustments aim to improve the test's performance and stability, ensuring it remains 'healthy' and reliable by achieving throughput above 8.0.
Highlights
- Test Configuration Adjustment: Modified environment variables in
.buildkite/scripts/tpu/config_v6e_1.env
to optimize test throughput. Specifically,MAX_NUM_SEQS
was reduced from 512 to 256, andMAX_NUM_BATCHED_TOKENS
was increased from 512 to 1024.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates test configuration parameters to improve throughput, as detailed in the description. The change is straightforward and effective. My review includes one suggestion to add a comment to the configuration file, capturing the rationale for the parameter tuning to improve future maintainability.
MAX_NUM_SEQS=256 | ||
MAX_NUM_BATCHED_TOKENS=1024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better maintainability, it would be helpful to add a comment explaining the rationale for these specific values. The PR description mentions this is to increase throughput, and capturing that context directly in the configuration file will be valuable for anyone adjusting these parameters in the future.
# Tuned to increase throughput on v6e TPUs by allowing larger token batches.
MAX_NUM_SEQS=256
MAX_NUM_BATCHED_TOKENS=1024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the update!
…ject#19994) Signed-off-by: Qiliang Cui <[email protected]>
…ject#19994) Signed-off-by: Qiliang Cui <[email protected]>
…ject#19994) Signed-off-by: Qiliang Cui <[email protected]> Signed-off-by: Will Eaton <[email protected]>
…ject#19994) Signed-off-by: Qiliang Cui <[email protected]>
…ject#19994) Signed-off-by: Qiliang Cui <[email protected]>
…ject#19994) Signed-off-by: Qiliang Cui <[email protected]> Signed-off-by: avigny <[email protected]>
Essential Elements of an Effective PR Description Checklist
Purpose
Update the test to have a throughput above the expected throughput so that it is healthy when enable the test.
Test Plan
Run the test with new parameter.
Test Result
Increased from 7.78 to always above 8.15