gqa added to mpt attn #1938
Merged
gqa added to mpt attn #1938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@megha95 Thanks for submitting the PR! Just a quick question: Which MPT model uses GQA? |
|
@WoosukKwon some of our customers want to try serving MPT with GQA. And, so this PR will help us enable it. |
WoosukKwon
reviewed
Dec 7, 2023
Comment on lines
144
to
145
| if self.num_kv_heads != self.num_heads: | ||
| input_metadata.attn_bias._bias = input_metadata.attn_bias._bias.unflatten(1, (self.num_kv_heads, self.num_queries_per_kv)) |
There was a problem hiding this comment.
@megha95 Could you elaborate more on this case? I think the current RoPE-based GQA models do not need this. Is this for GQA + ALiBi?
WoosukKwon
approved these changes
Dec 12, 2023
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Co-authored-by: Woosuk Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mpt.py modified to support GQA in MPTAttention