Skip to content

[Deprecation] Remove unused sync methods in async_timeout #18792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

[Deprecation] Remove unused sync methods in async_timeout #18792

merged 1 commit into from
May 28, 2025

Conversation

DarkLight1337
Copy link
Member

This method isn't used in vLLM so it's safe to remove it.

@DarkLight1337 DarkLight1337 requested a review from Isotr0py May 28, 2025 02:57
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label May 28, 2025
@DarkLight1337 DarkLight1337 requested a review from mgoin May 28, 2025 02:58
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 28, 2025 02:58
@DarkLight1337 DarkLight1337 disabled auto-merge May 28, 2025 02:58
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 requested a review from simon-mo May 28, 2025 05:08
@DarkLight1337 DarkLight1337 merged commit 0f0926b into vllm-project:main May 28, 2025
69 checks passed
@DarkLight1337 DarkLight1337 deleted the deprecate-sync-timeout branch May 28, 2025 07:08
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
@DarkLight1337 @amitm02
[Deprecation] Remove unused sync methods in async_timeout (vllm-pro…
ca91a87 
…ject#18792)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: amit <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@DarkLight1337 @minpeter
[Deprecation] Remove unused sync methods in async_timeout (vllm-pro…
5a8d7fa 
…ject#18792)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@mgoin mgoin Awaiting requested review from mgoin

@simon-mo simon-mo Awaiting requested review from simon-mo

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkLight1337 @Isotr0py