[Docs] Add developer doc about CI failures #18782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This document describes what to do when CI fails on a PR and appears to be unrelated to the changes in the PR. We have a GitHub dashboard of open issues related to failing tests. This doc encourages more people to help file and fix these issues. Co-authored-by: Mark McLoughlin <[email protected]> Signed-off-by: Russell Bryant <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
simon-mo
approved these changes
May 28, 2025
Signed-off-by: Russell Bryant <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Russell Bryant <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
russellb
commented
May 30, 2025
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
|
Can you fix pre-commit? |
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
DarkLight1337
approved these changes
Jun 3, 2025
github-actions
bot
added
the
ready
hmellor
reviewed
Jun 3, 2025
hmellor
reviewed
Jun 3, 2025
hmellor
reviewed
Jun 3, 2025
Comment on lines
+44
to
+59
| <details> | ||
| <summary>Logs:</summary> | ||
|
|
||
| ```text | ||
| ERROR 05-20 03:26:38 [dump_input.py:68] Dumping input data | ||
| --- Logging error --- | ||
| Traceback (most recent call last): | ||
| File "/usr/local/lib/python3.12/dist-packages/vllm/v1/engine/core.py", line 203, in execute_model | ||
| return self.model_executor.execute_model(scheduler_output) | ||
| ... | ||
| FAILED failing/test.py:failing_test1 - Failure description | ||
| FAILED failing/test.py:failing_test2 - Failure description | ||
| FAILED failing/test.py:failing_test3 - Failure description | ||
| ``` | ||
|
|
||
| </details> |
There was a problem hiding this comment.
hmellor
approved these changes
Jun 3, 2025
Signed-off-by: Russell Bryant <[email protected]> Co-authored-by: Harry Mellor <[email protected]>
minpeter
pushed a commit
to minpeter/vllm
that referenced
this pull request
Jun 24, 2025
Signed-off-by: Russell Bryant <[email protected]> Co-authored-by: Mark McLoughlin <[email protected]> Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: minpeter <[email protected]>
avigny
pushed a commit
to avigny/vllm
that referenced
this pull request
Jul 31, 2025
Signed-off-by: Russell Bryant <[email protected]> Co-authored-by: Mark McLoughlin <[email protected]> Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: avigny <[email protected]>
googlercolin
pushed a commit
to googlercolin/vllm
that referenced
this pull request
Aug 29, 2025
Signed-off-by: Russell Bryant <[email protected]> Co-authored-by: Mark McLoughlin <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document describes what to do when CI fails on a PR and appears to
be unrelated to the changes in the PR. We have a GitHub dashboard of
open issues related to failing tests. This doc encourages more people to
help file and fix these issues.
Co-authored-by: Mark McLoughlin [email protected]
Signed-off-by: Russell Bryant [email protected]
Preview: https://vllm--18782.org.readthedocs.build/en/18782/contributing/ci-failures.html