Skip to content

[Bugfix]: correctly propagate errors message caught at the chat_templating step to the client #18769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

gcalmettes
Copy link
Contributor

@gcalmettes gcalmettes commented May 27, 2025

This PR ensures the error message from the exception caught during the chat templating step is correctly propagated to the client.
The previous implementation converted the error so it is caught in the entrypoints, however, the error message was not propagated, which resulted in an empty message being sent back to the client:

Before:

openai.BadRequestError: Error code: 400 - {'object': 'error', 'message': '', 'type': 'BadRequestError', 'param': None, 'code': 400}

After

openai.BadRequestError: Error code: 400 - {'object': 'error', 'message': 'After the optional system message, conversation roles must alternate user/assistant/user/assistant/...', 'type': 'BadRequestError', 'param': None, 'code': 400}

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label May 27, 2025
@gcalmettes gcalmettes force-pushed the fix/propagate-errors branch from 3dfd73e to 1f005df Compare May 27, 2025 16:58
@gcalmettes
Copy link
Contributor Author

cc: @DarkLight1337, follow up of #16769 to improve the user experience

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 28, 2025 01:47
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 28, 2025
@DarkLight1337 DarkLight1337 merged commit 9a21e33 into vllm-project:main May 28, 2025
72 checks passed
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
…ating step to the client (vllm-project#18769)

Signed-off-by: Guillaume Calmettes <[email protected]>
Signed-off-by: amit <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
…ating step to the client (vllm-project#18769)

Signed-off-by: Guillaume Calmettes <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants