-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[DO NOT MERGE] Revert to pre #15777 #18462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…llm-project#18316)" This reverts commit 47fda6d. Signed-off-by: Mark McLouglin <[email protected]>
This reverts commit dcfe952. Signed-off-by: Mark McLoughlin <[email protected]>
…#15777)" This reverts commit 7fdfa01. Signed-off-by: Mark McLoughlin <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
The multi-GPU tests are indeed caused by the PRs reverted here, since they pass now. |
And @LucasWilkinson as well |
Also it seems this fixes the entrypoints tests (not 100% sure though since the test is flaky) |
All failures other than entrypoint test failure seems unrelated to this PR. I'm looking into the entrypoint test. |
I have unblocked tests in https://buildkite.com/vllm/ci/builds/20315 (the PR prior to #18316) to check whether the failing distributed tests are from #18316 or from some other PR |
This pull request has merge conflicts that must be resolved before it can be |
Closing in favor of #18543 |
Revert recent changes to Docker file - #15777, #18095, #18316
To see if #18425, #18418, #18245, and #18416 can be reproduced without this PR