Skip to content

[DO NOT MERGE] Revert to pre #15777 #18462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

markmc
Copy link
Member

@markmc markmc commented May 21, 2025

Revert recent changes to Docker file - #15777, #18095, #18316

To see if #18425, #18418, #18245, and #18416 can be reproduced without this PR

@markmc markmc added the ready ONLY add when PR is ready to merge/full CI is needed label May 21, 2025
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

DarkLight1337 commented May 21, 2025

The multi-GPU tests are indeed caused by the PRs reverted here, since they pass now.

@DarkLight1337
Copy link
Member

cc @WoosukKwon @mgoin

@DarkLight1337
Copy link
Member

And @LucasWilkinson as well

@DarkLight1337
Copy link
Member

Also it seems this fixes the entrypoints tests (not 100% sure though since the test is flaky)

@simon-mo
Copy link
Collaborator

All failures other than entrypoint test failure seems unrelated to this PR. I'm looking into the entrypoint test.

@DarkLight1337
Copy link
Member

DarkLight1337 commented May 21, 2025

I have unblocked tests in https://buildkite.com/vllm/ci/builds/20315 (the PR prior to #18316) to check whether the failing distributed tests are from #18316 or from some other PR

Copy link

mergify bot commented May 22, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @markmc.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 22, 2025
@markmc
Copy link
Member Author

markmc commented May 22, 2025

Closing in favor of #18543

@markmc markmc closed this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build needs-rebase ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants