-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[Core] Add Lora Support to Beam Search #18346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Thank you, will look at this PR ASAP |
99647fc
to
fdac266
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
@alex-jw-brooks Please sync with the main branch to verify if it can fix the CI failure |
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]>
fdac266
to
e16d9c9
Compare
Awesome, thanks for the review @jeejeelee! Rebased this PR, but it looks like the image build timed out. Could you please retry it? |
Retrying |
Awesome, thanks @DarkLight1337! I think the test failures look unrelated |
Signed-off-by: Alex-Brooks <[email protected]> Signed-off-by: amit <[email protected]>
Signed-off-by: Alex-Brooks <[email protected]> Signed-off-by: minpeter <[email protected]>
Adds support for passing lora adapters for beam search (offline and online).
FIX #17205
Sample usage (offline):
sample output:
Sample usage (online):
Start the server:
Sample output:
CC @jeejeelee