Skip to content

Remove checks for None for fields which should never be None #17985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 28, 2025
Merged

Remove checks for None for fields which should never be None #17985

merged 4 commits into from
May 28, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented May 12, 2025 •
edited by github-actions bot
Loading

Updates some checks in config.py so that:

  • We don't check for None if the argument should never be None
  • We do check for None instead of truthiness if the argument could be None

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor
Fix tests
a8794da 
Signed-off-by: Harry Mellor <[email protected]>
@mergify mergify bot added the frontend label May 12, 2025
@hmellor hmellor requested a review from DarkLight1337 May 16, 2025 06:40
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 16, 2025 07:13
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 16, 2025
@mergify Mergify
Copy link

mergify bot commented May 17, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @hmellor.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 17, 2025
@mergify mergify bot removed the needs-rebase label May 28, 2025
@DarkLight1337 DarkLight1337 merged commit 6dbe5b5 into vllm-project:main May 28, 2025
63 checks passed
@hmellor hmellor deleted the simplify-vllm-config-post-init branch May 29, 2025 00:02
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
@hmellor @amitm02
Remove checks for None for fields which should never be None (vll…
2ce1657 
…m-project#17985)

Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: amit <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@hmellor @minpeter
Remove checks for None for fields which should never be None (vll…
f25c04e 
…m-project#17985)

Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmellor @DarkLight1337