Skip to content

Change top_k to be disabled with 0 (still accept -1 for now) #17773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2025
Merged

Change top_k to be disabled with 0 (still accept -1 for now) #17773

merged 3 commits into from
May 9, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented May 7, 2025 •
edited by github-actions bot
Loading

This better matches Hugging Face, the main other place top_k is used.

Closes #17553.

@hmellor
Change top_k to be disabled with 0 (still accept -1 for now)
0b13b87 
This better matches Hugging Face, the main other place `top_k` is used.

Signed-off-by: Harry Mellor <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added frontend tpu Related to Google TPUs labels May 7, 2025
@hmellor hmellor mentioned this pull request May 7, 2025
Closed
DarkLight1337
DarkLight1337 reviewed May 7, 2025
View reviewed changes
@hmellor hmellor requested a review from DarkLight1337 May 8, 2025 11:58
NickLucche
NickLucche approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@NickLucche NickLucche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this also better matches the behavior in V1

DarkLight1337
DarkLight1337 approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 9, 2025 08:08
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 9, 2025
@DarkLight1337 DarkLight1337 merged commit c6798ba into vllm-project:main May 9, 2025
72 checks passed
@hmellor hmellor deleted the topk-0 branch May 9, 2025 11:32
princepride pushed a commit to princepride/vllm that referenced this pull request May 10, 2025
@hmellor @princepride
Change top_k to be disabled with 0 (still accept -1 for now) (v…
d689a9b 
…llm-project#17773)

Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: 汪志鹏 <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@hmellor
Change top_k to be disabled with 0 (still accept -1 for now) (v…
865088c 
…llm-project#17773)

Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@hmellor @mawong-amd
Change top_k to be disabled with 0 (still accept -1 for now) (v…
50ec6f3 
…llm-project#17773)

Signed-off-by: Harry Mellor <[email protected]>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@hmellor
Change top_k to be disabled with 0 (still accept -1 for now) (v…
2c6ad70 
…llm-project#17773)

Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@hmellor @minpeter
Change top_k to be disabled with 0 (still accept -1 for now) (v…
766dcab 
…llm-project#17773)

Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: minpeter <[email protected]>
@tanujtiwari1998 tanujtiwari1998 mentioned this pull request Jul 8, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njhill njhill njhill left review comments

@NickLucche NickLucche NickLucche approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: top_k: 0 in generation_config.json can't disable top-k sampling
4 participants
@hmellor @NickLucche @njhill @DarkLight1337