-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[Attention] MLA move rotary embedding to cuda-graph region #17668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Attention] MLA move rotary embedding to cuda-graph region #17668
Conversation
Signed-off-by: Lucas Wilkinson <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me and nice simplifications!
…ect#17668) Signed-off-by: Lucas Wilkinson <[email protected]> Signed-off-by: 汪志鹏 <[email protected]>
…ect#17668) Signed-off-by: Lucas Wilkinson <[email protected]> Signed-off-by: Mu Huai <[email protected]>
…ect#17668) Signed-off-by: Lucas Wilkinson <[email protected]>
…ect#17668) Signed-off-by: Lucas Wilkinson <[email protected]> Signed-off-by: Yuqi Zhang <[email protected]>
…ect#17668) Signed-off-by: Lucas Wilkinson <[email protected]> Signed-off-by: minpeter <[email protected]>
Following on from #17484, with: #14770 we are no longer materializing the absorbed matrices so we can move the rotary embeddings into the cuda-graph region lowering CPU overhead:
Perf
Main
CPU time for

unified_attention
is 216usPR
CPU time for

unified_attention
is 149usAccuracy