Skip to content

[Neuron][Build] Require setuptools >= 77.0.3 for PEP 639 #17603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2025
Merged

[Neuron][Build] Require setuptools >= 77.0.3 for PEP 639 #17603

merged 1 commit into from
May 3, 2025

Conversation

liangfu
Copy link
Contributor

@liangfu liangfu commented May 2, 2025 •
edited by github-actions bot
Loading

Following #17389, added required setuptools and packaging version for requirements/neuron.txt .

FIX #17464

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label May 2, 2025
aws-satyajith
aws-satyajith approved these changes May 3, 2025
View reviewed changes
Copy link
Contributor

@aws-satyajith aws-satyajith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this change. Will pull this this into #16357 as well once merged.

@khluu khluu enabled auto-merge (squash) May 3, 2025 01:10
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 3, 2025
@khluu khluu merged commit 22c6f63 into vllm-project:main May 3, 2025
51 of 53 checks passed
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@liangfu
[Neuron][Build] Require setuptools >= 77.0.3 for PEP 639 (vllm-projec…
74dc108 
…t#17603)

Signed-off-by: Liangfu Chen <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@liangfu @mawong-amd
[Neuron][Build] Require setuptools >= 77.0.3 for PEP 639 (vllm-projec…
a3de12a 
…t#17603)

Signed-off-by: Liangfu Chen <[email protected]>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@liangfu
[Neuron][Build] Require setuptools >= 77.0.3 for PEP 639 (vllm-projec…
2e741f0 
…t#17603)

Signed-off-by: Liangfu Chen <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@liangfu @minpeter
[Neuron][Build] Require setuptools >= 77.0.3 for PEP 639 (vllm-projec…
ba5cf01 
…t#17603)

Signed-off-by: Liangfu Chen <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khluu khluu khluu approved these changes

+1 more reviewer

@aws-satyajith aws-satyajith aws-satyajith approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: configuration error: project.license must be valid exactly by one definition (2 matches found)
3 participants
@liangfu @khluu @aws-satyajith