Skip to content

Automatically tell users that dict args must be valid JSON in CLI #17577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 2, 2025
Merged

Automatically tell users that dict args must be valid JSON in CLI #17577

merged 3 commits into from
May 2, 2025
+15 −13

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented May 2, 2025 •
edited by github-actions bot
Loading

Allows us to remove info about JSON from config.py, where it doesn't make sense.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor mentioned this pull request May 2, 2025
Merged
@hmellor
Add test
331e500 
Signed-off-by: Harry Mellor <[email protected]>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 2, 2025 09:37
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 2, 2025
@vllm-bot vllm-bot merged commit 785d75a into vllm-project:main May 2, 2025
70 of 73 checks passed
@hmellor hmellor deleted the json-tip branch May 2, 2025 12:32
radeksm pushed a commit to radeksm/vllm that referenced this pull request May 2, 2025
@hmellor @radeksm
Automatically tell users that dict args must be valid JSON in CLI (vl…
3c75c05 
…lm-project#17577)

Signed-off-by: Harry Mellor <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@hmellor
Automatically tell users that dict args must be valid JSON in CLI (vl…
e03980e 
…lm-project#17577)

Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@hmellor @mawong-amd
Automatically tell users that dict args must be valid JSON in CLI (vl…
8c0eb12 
…lm-project#17577)

Signed-off-by: Harry Mellor <[email protected]>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@hmellor
Automatically tell users that dict args must be valid JSON in CLI (vl…
6e8f38b 
…lm-project#17577)

Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@hmellor @minpeter
Automatically tell users that dict args must be valid JSON in CLI (vl…
d172082 
…lm-project#17577)

Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmellor @DarkLight1337 @vllm-bot