Skip to content

[Doc] note that not all unit tests pass on CPU platforms #17554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

[Doc] note that not all unit tests pass on CPU platforms #17554

merged 1 commit into from
May 2, 2025

Conversation

davidxia
Copy link
Contributor

@davidxia davidxia commented May 1, 2025

and to rely on CI for running all the unit tests.

@davidxia davidxia marked this pull request as ready for review May 1, 2025 19:20
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label May 1, 2025
@aarnphm aarnphm requested a review from hmellor May 1, 2025 19:35
@aarnphm
Copy link
Collaborator

aarnphm commented May 1, 2025

Can you reformat the title to be [Doc] ... thanks

@davidxia
[Doc] note that not all unit tests pass on CPU platforms
46749f2 
and to rely on CI for running all the unit tests.

Signed-off-by: David Xia <[email protected]>
@davidxia
Copy link
Contributor Author

davidxia commented May 1, 2025

Can you reformat the title to be [Doc] ... thanks

yup, done

@davidxia davidxia changed the title docs: note that not all unit tests pass on CPU platforms [Doc] note that not all unit tests pass on CPU platforms May 1, 2025
@hmellor hmellor enabled auto-merge (squash) May 1, 2025 21:22
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 1, 2025
@hmellor hmellor merged commit afb12e4 into vllm-project:main May 2, 2025
51 checks passed
radeksm pushed a commit to radeksm/vllm that referenced this pull request May 2, 2025
@davidxia @radeksm
[Doc] note that not all unit tests pass on CPU platforms (vllm-projec…
dc7c5e8 
…t#17554)

Signed-off-by: David Xia <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@davidxia
[Doc] note that not all unit tests pass on CPU platforms (vllm-projec…
f398ea2 
…t#17554)

Signed-off-by: David Xia <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@davidxia @mawong-amd
[Doc] note that not all unit tests pass on CPU platforms (vllm-projec…
4ae37a0 
…t#17554)

Signed-off-by: David Xia <[email protected]>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@davidxia
[Doc] note that not all unit tests pass on CPU platforms (vllm-projec…
9f852bb 
…t#17554)

Signed-off-by: David Xia <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@davidxia @minpeter
[Doc] note that not all unit tests pass on CPU platforms (vllm-projec…
c58f18a 
…t#17554)

Signed-off-by: David Xia <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmellor hmellor hmellor approved these changes

@aarnphm aarnphm aarnphm approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidxia @aarnphm @hmellor