Skip to content

Improve literal dataclass field conversion to argparse argument #17391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 29, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Apr 29, 2025

  • Enforces that Literals are merged like Literal[Literal[1], Literal[2]] instead of Union[Literal[1], Literal[2]] (this stops us from needing complicated Literal merging in get_kwargs)
  • Handle list[Literal] where we want the argument to accept multiple values from a set of choices
  • Adds tests for both ofd the above changes

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the conversion of Literal type hints for argparse by introducing a helper function (literal_to_kwargs) to centralize the logic. It also enforces that fields using Literals must merge nested literal values (e.g. Literal[Literal[1], Literal[2]] rather than Union[Literal[1], Literal[2]]), and adds tests to validate these behaviors.

  • Consolidates Literal-to-kwargs conversion into a single helper function.
  • Enforces stricter validation for Literal types in dataclass field definitions.
  • Adds test cases to ensure proper handling of Literal and list[Literal] types.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
vllm/engine/arg_utils.py Introduces literal_to_kwargs and updates get_kwargs accordingly.
vllm/config.py Updates field validation to mandate merged Literal types.
tests/test_config.py Adds tests to check proper configuration and error messages.
tests/engine/test_arg_utils.py Adds tests for literal_to_kwargs behavior.

Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@russellb russellb enabled auto-merge (squash) April 29, 2025 14:06
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 29, 2025
@russellb russellb merged commit 2ef5d10 into vllm-project:main Apr 29, 2025
49 of 51 checks passed
@hmellor hmellor deleted the config-literal-handling branch April 29, 2025 16:41
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
radeksm pushed a commit to radeksm/vllm that referenced this pull request May 2, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants