-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[V1] Remove num_input_tokens from attn_metadata #17193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Chen Zhang <[email protected]>
Signed-off-by: Chen Zhang <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
…kens Signed-off-by: Chen Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Chen Zhang <[email protected]>
Signed-off-by: Chen Zhang <[email protected]>
Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: Mu Huai <[email protected]>
Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: Yuqi Zhang <[email protected]>
Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: minpeter <[email protected]>
num_input_tokens
is not related to attention and only used inset_forward_context
, so I prefer to remove it from attention_metadata and pass it to set_forward_context explicitly.