Support fused add rmsnorm for LLaMA #1667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoosukKwon
reviewed
Nov 16, 2023
There was a problem hiding this comment.
@beginlner Thanks for the PR! Good work. Left some minor comments. Please take a look at them.
WoosukKwon
approved these changes
Nov 19, 2023
yxl
pushed a commit
to yxl/vllm
that referenced
this pull request
Nov 29, 2023
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
jikunshang
pushed a commit
to jikunshang/vllm
that referenced
this pull request
Jul 29, 2025
…#1667) Because libfrabic need consume some HBM memory, reduce util to 0.7. Or else vLLM may crash in 32k model length (30k/2k)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces CPU overhead, increasing the end-to-end token generation speed in LLaMA by 10%.