Skip to content

Conversation

WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Mar 7, 2025

This reverts commit ada1921. (PR #12613)

Copy link

github-actions bot commented Mar 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@WoosukKwon WoosukKwon requested a review from mgoin March 7, 2025 00:23
@mergify mergify bot added the ci/build label Mar 7, 2025
@dilipgb
Copy link
Contributor

dilipgb commented Mar 7, 2025

@WoosukKwon I request not to proceed with the revert before we discuss and conclude on the needs.

I have replied to your comments on other PR. Please check it once.

@WoosukKwon WoosukKwon closed this Mar 7, 2025
@WoosukKwon WoosukKwon deleted the revert-12613 branch March 28, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants