-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[Bugfix][Frontend] Fix validation of logprobs
in ChatCompletionRequest
#14352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix][Frontend] Fix validation of logprobs
in ChatCompletionRequest
#14352
Conversation
Signed-off-by: Sebastian Schönnenbeck <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
logprobs
in ChatCompletionRequest
logprobs
in ChatCompletionRequest
Sorry I'm quite busy now, @hmellor can you help review the PR? |
@schoennenbeck I agree that the class should be able to be created with its default values. What is the behaviour when |
You will get logprobs informations for the token that was selected but not any additional logprobs info (the top_logprobs list will be empty). That is a valid combination. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…uest` (vllm-project#14352) Signed-off-by: Sebastian Schönnenbeck <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
…uest` (vllm-project#14352) Signed-off-by: Sebastian Schönnenbeck <[email protected]>
…uest` (vllm-project#14352) Signed-off-by: Sebastian Schönnenbeck <[email protected]> Signed-off-by: Mu Huai <[email protected]>
This fixes the validation of
logprobs
andtop_logprobs
forChatCompletionRequest
so that the class accepts its own default values.FIX #14351