Skip to content

Conversation

schoennenbeck
Copy link
Contributor

@schoennenbeck schoennenbeck commented Mar 6, 2025

This fixes the validation of logprobs and top_logprobs for ChatCompletionRequest so that the class accepts its own default values.

FIX #14351

Signed-off-by: Sebastian Schönnenbeck <[email protected]>
Copy link

github-actions bot commented Mar 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Mar 6, 2025
@schoennenbeck schoennenbeck changed the title [Bugfix] Fix validation of logprobs in ChatCompletionRequest [Bugfix][Frontend] Fix validation of logprobs in ChatCompletionRequest Mar 6, 2025
@DarkLight1337
Copy link
Member

Sorry I'm quite busy now, @hmellor can you help review the PR?

@hmellor
Copy link
Member

hmellor commented Mar 17, 2025

@schoennenbeck I agree that the class should be able to be created with its default values. What is the behaviour when log_probs=True and top_logprobs=0?

@schoennenbeck
Copy link
Contributor Author

You will get logprobs informations for the token that was selected but not any additional logprobs info (the top_logprobs list will be empty). That is a valid combination.

Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hmellor hmellor enabled auto-merge (squash) March 17, 2025 14:14
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 17, 2025
@vllm-bot vllm-bot merged commit dd73202 into vllm-project:main Mar 18, 2025
46 of 49 checks passed
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
…uest` (vllm-project#14352)

Signed-off-by: Sebastian Schönnenbeck <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@schoennenbeck schoennenbeck deleted the fix/ChatCompletionRequest-validation branch May 22, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ChatCompletionRequest rejects its own defaults
4 participants