-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[Misc][Platform] Improve log info #13732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
0f66a49
to
3378c63
Compare
vllm/platforms/__init__.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think it helps here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used for print error stack for detail info. For example, the error raise by
vllm/vllm/platforms/__init__.py
Line 68 in 51010a1
raise e |
will be catch here.
I change it to debug level to keep the same with other logger.
we can add some debug level logging in functions like vllm/vllm/platforms/__init__.py Line 48 in f90a375
and then, at vllm/vllm/platforms/__init__.py Line 212 in f90a375
we can have one more line to tell users to turn on debug logging if the detected platform is not correct. |
Signed-off-by: wangxiyuan <[email protected]>
3378c63
to
8162b67
Compare
Nice way. I added more log. Please take a look again. Thanks. |
finished in #14195 . thanks for the initiative! |
Print the error info when failed to load platform during initialization. It helps user to get the origin info clear.