Skip to content

Conversation

wangxiyuan
Copy link
Contributor

@wangxiyuan wangxiyuan commented Feb 24, 2025

Print the error info when failed to load platform during initialization. It helps user to get the origin info clear.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think it helps here?

Copy link
Contributor Author

@wangxiyuan wangxiyuan Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used for print error stack for detail info. For example, the error raise by


will be catch here.

I change it to debug level to keep the same with other logger.

@youkaichao
Copy link
Member

we can add some debug level logging in functions like

def cuda_platform_plugin() -> Optional[str]:

and then, at

"No platform detected, vLLM is running on UnspecifiedPlatform")

we can have one more line to tell users to turn on debug logging if the detected platform is not correct.

@wangxiyuan
Copy link
Contributor Author

we can add some debug level logging in functions like

def cuda_platform_plugin() -> Optional[str]:

and then, at

"No platform detected, vLLM is running on UnspecifiedPlatform")

we can have one more line to tell users to turn on debug logging if the detected platform is not correct.

Nice way. I added more log. Please take a look again. Thanks.

@youkaichao
Copy link
Member

finished in #14195 . thanks for the initiative!

@youkaichao youkaichao closed this Mar 4, 2025
@wangxiyuan wangxiyuan deleted the log_improve branch March 21, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants