Skip to content

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Feb 23, 2025

No description provided.

p
Signed-off-by:  <>
@khluu khluu requested review from hmellor and youkaichao February 23, 2025 21:31
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we changing it in the test? I think we should update the served_model_name directly in

self.model = f"{MODEL_WEIGHTS_S3_BUCKET}/{self.model}"

?

@khluu
Copy link
Collaborator Author

khluu commented Feb 24, 2025

why are we changing it in the test? I think we should update the served_model_name directly in

self.model = f"{MODEL_WEIGHTS_S3_BUCKET}/{self.model}"

?

Isn't the test not asserting value against served_model_name? I thought it was fixed in the params

@khluu khluu enabled auto-merge (squash) February 24, 2025 03:39
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 24, 2025
@khluu khluu merged commit f90a375 into main Feb 24, 2025
42 of 44 checks passed
@khluu khluu deleted the khluu/s3_metrics branch February 24, 2025 06:32
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
…on (vllm-project#13727)

Signed-off-by: <>
Co-authored-by: EC2 Default User <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants