-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Closed as not planned
Closed as not planned
Copy link
Labels
bugSomething isn't workingSomething isn't workingstaleOver 90 days of inactivityOver 90 days of inactivity
Description
Your current environment
The output of `python collect_env.py`
Environment is not relevant for this issue.
🐛 Describe the bug
The current implementation for TP for Mamba2 is complicated for the in_proj
, because the gate, projection, state space, heads, are all fused into this one layer. And furthermore, we also need to consider different possibilities if the number of groups divide the number of heads or not, see #13660.
For now the implementation of TP is simplified:
- limited to the case of
num_groups == 1
ifnum_groups
does not dividenum_heads
#13660. - will does not support TP > 1 if the mamba2 mixer is quantised, see #14617
However for large models, it may be useful to support TP > 1 with quant layers, even in some special cases of num_heads
and num_groups
. cc: @tlrmchlsmth
Before submitting a new issue...
- Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingstaleOver 90 days of inactivityOver 90 days of inactivity