Skip to content

Conversation

@jikunshang
Copy link
Collaborator

@jikunshang jikunshang commented Nov 14, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS ABOVE HAVE BEEN CONSIDERED.

Purpose

enable use source code path build for sycl-tla

Test Plan

Test Result

(Optional) Documentation Update

BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)

Copilot AI review requested due to automatic review settings November 14, 2025 00:45
Signed-off-by: Kunshang Ji <[email protected]>
Signed-off-by: Kunshang Ji <[email protected]>
@jikunshang jikunshang force-pushed the kunshang/sycl-tla-src branch from aba7218 to 01db71f Compare November 14, 2025 00:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables building vllm-xpu-kernels with a custom cutlass-sycl source code path and updates the repository reference from cutlass-sycl to sycl-tla.

Key Changes:

  • Adds support for specifying a custom CUTLASS source directory via the VLLM_CUTLASS_SRC_DIR environment variable
  • Updates the Git repository URL from intel/cutlass-sycl to intel/sycl-tla
  • Adds documentation for using a custom cutlass source code base

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
README.md Adds documentation explaining how to use a custom cutlass-sycl code base via the VLLM_CUTLASS_SRC_DIR environment variable
CMakeLists.txt Implements logic to use custom CUTLASS source directory when VLLM_CUTLASS_SRC_DIR is set, and updates the Git repository URL to sycl-tla

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

python3 -m build --wheel --no-isolation
```

if you want to use a custom cutlass-sycl code base, you can follow step:
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed 'step' to 'these steps' for grammatical correctness.

Suggested change
if you want to use a custom cutlass-sycl code base, you can follow step:
if you want to use a custom cutlass-sycl code base, you can follow these steps:

Copilot uses AI. Check for mistakes.

if you want to use a custom cutlass-sycl code base, you can follow step:
```
#prepare cutlass source code
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added space after '#' to follow Markdown comment convention: '# prepare cutlass source code'.

Suggested change
#prepare cutlass source code
# prepare cutlass source code

Copilot uses AI. Check for mistakes.
set(VLLM_CUTLASS_SRC_DIR $ENV{VLLM_CUTLASS_SRC_DIR})
endif()
if(VLLM_CUTLASS_SRC_DIR)
if(NOT IS_ABSOLUTE VLLM_CUTLASS_SRC_DIR)
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing variable expansion syntax. Should be ${VLLM_CUTLASS_SRC_DIR} to properly check if the path is absolute.

Suggested change
if(NOT IS_ABSOLUTE VLLM_CUTLASS_SRC_DIR)
if(NOT IS_ABSOLUTE "${VLLM_CUTLASS_SRC_DIR}")

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant