-
Notifications
You must be signed in to change notification settings - Fork 14
enable use source code path build for sycl-tla #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kunshang Ji <[email protected]>
Signed-off-by: Kunshang Ji <[email protected]>
Signed-off-by: Kunshang Ji <[email protected]>
aba7218 to
01db71f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables building vllm-xpu-kernels with a custom cutlass-sycl source code path and updates the repository reference from cutlass-sycl to sycl-tla.
Key Changes:
- Adds support for specifying a custom CUTLASS source directory via the
VLLM_CUTLASS_SRC_DIRenvironment variable - Updates the Git repository URL from
intel/cutlass-sycltointel/sycl-tla - Adds documentation for using a custom cutlass source code base
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| README.md | Adds documentation explaining how to use a custom cutlass-sycl code base via the VLLM_CUTLASS_SRC_DIR environment variable |
| CMakeLists.txt | Implements logic to use custom CUTLASS source directory when VLLM_CUTLASS_SRC_DIR is set, and updates the Git repository URL to sycl-tla |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| python3 -m build --wheel --no-isolation | ||
| ``` | ||
|
|
||
| if you want to use a custom cutlass-sycl code base, you can follow step: |
Copilot
AI
Nov 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed 'step' to 'these steps' for grammatical correctness.
| if you want to use a custom cutlass-sycl code base, you can follow step: | |
| if you want to use a custom cutlass-sycl code base, you can follow these steps: |
|
|
||
| if you want to use a custom cutlass-sycl code base, you can follow step: | ||
| ``` | ||
| #prepare cutlass source code |
Copilot
AI
Nov 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added space after '#' to follow Markdown comment convention: '# prepare cutlass source code'.
| #prepare cutlass source code | |
| # prepare cutlass source code |
| set(VLLM_CUTLASS_SRC_DIR $ENV{VLLM_CUTLASS_SRC_DIR}) | ||
| endif() | ||
| if(VLLM_CUTLASS_SRC_DIR) | ||
| if(NOT IS_ABSOLUTE VLLM_CUTLASS_SRC_DIR) |
Copilot
AI
Nov 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing variable expansion syntax. Should be ${VLLM_CUTLASS_SRC_DIR} to properly check if the path is absolute.
| if(NOT IS_ABSOLUTE VLLM_CUTLASS_SRC_DIR) | |
| if(NOT IS_ABSOLUTE "${VLLM_CUTLASS_SRC_DIR}") |
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS ABOVE HAVE BEEN CONSIDERED.
Purpose
enable use source code path build for sycl-tla
Test Plan
Test Result
(Optional) Documentation Update
BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)