Skip to content

Upstream compatibility tests #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 31, 2025
Merged

Upstream compatibility tests #343

merged 22 commits into from
Jul 31, 2025

Conversation

maxdebayser
Copy link
Collaborator

Since we test against "main" and "default" vLLM versions in our tests, we often add code to make "main" work ahead of our official support. But it's easy to forget this compatibility code and it can become technical debt later. In this PR I'm adding a new test file to that verifies "main" and "default" imports from vLLM so that the "default" tests starts failing one a compatibility code is not longer needed.

Signed-off-by: Max de Bayser <[email protected]>
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@maxdebayser maxdebayser force-pushed the embed_upstream_compat branch from 8d30166 to 0a7a21e Compare July 28, 2025 19:57
Signed-off-by: Max de Bayser <[email protected]>
Signed-off-by: Max de Bayser <[email protected]>
@maxdebayser maxdebayser force-pushed the embed_upstream_compat branch from 112e780 to 3fedfb3 Compare July 30, 2025 13:09
Signed-off-by: Max de Bayser <[email protected]>
Signed-off-by: Max de Bayser <[email protected]>
Signed-off-by: Max de Bayser <[email protected]>
Signed-off-by: Max de Bayser <[email protected]>
Signed-off-by: Max de Bayser <[email protected]>
Copy link
Collaborator

@joerunde joerunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPGTM, would ideally like a smaller set of tests for backwards compatibility but we can get to that later

edit: Max is already on it 😎 ⚡⚡⚡

@joerunde joerunde enabled auto-merge (squash) July 31, 2025 20:43
@github-actions github-actions bot added the ready label Jul 31, 2025
@joerunde joerunde merged commit 88ca01e into main Jul 31, 2025
19 of 21 checks passed
@joerunde joerunde deleted the embed_upstream_compat branch July 31, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants