-
Notifications
You must be signed in to change notification settings - Fork 592
[v0.11.0]Upgrade cann to 8.3.rc2 #4332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v0.11.0]Upgrade cann to 8.3.rc2 #4332
Conversation
Signed-off-by: MrZ20 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the CANN dependency to version 8.3.rc2 across various Dockerfiles, configuration files, and documentation. The changes are mostly correct and consistent. However, I've noticed one instance in docs/source/installation.md where the CANN version in the requirements table (line 15) was not updated from >= 8.3.RC1 to >= 8.3.RC2. Please update this to ensure consistency. Additionally, I've provided a suggestion to improve the maintainability of the installation script in the same file by using variables to avoid repetition.
| wget --header="Referer: https://www.hiascend.com/" https://ascend-repo.obs.cn-east-2.myhuaweicloud.com/CANN/CANN%208.3.RC2/Ascend-cann-toolkit_8.3.RC2_linux-"$(uname -i)".run | ||
| chmod +x ./Ascend-cann-toolkit_8.3.RC2_linux-"$(uname -i)".run | ||
| ./Ascend-cann-toolkit_8.3.RC2_linux-"$(uname -i)".run --full | ||
| # https://ascend-repo.obs.cn-east-2.myhuaweicloud.com/Milan-ASL/Milan-ASL%20V100R001C22B800TP052/Ascend-cann-kernels-910b_8.3.rc2_linux-aarch64.run | ||
|
|
||
| source /usr/local/Ascend/ascend-toolkit/set_env.sh | ||
| wget --header="Referer: https://www.hiascend.com/" https://ascend-repo.obs.cn-east-2.myhuaweicloud.com/CANN/CANN%208.3.RC1/Ascend-cann-kernels-910b_8.3.RC1_linux-"$(uname -i)".run | ||
| chmod +x ./Ascend-cann-kernels-910b_8.3.RC1_linux-"$(uname -i)".run | ||
| ./Ascend-cann-kernels-910b_8.3.RC1_linux-"$(uname -i)".run --install | ||
| wget --header="Referer: https://www.hiascend.com/" https://ascend-repo.obs.cn-east-2.myhuaweicloud.com/CANN/CANN%208.3.RC2/Ascend-cann-kernels-910b_8.3.RC2_linux-"$(uname -i)".run | ||
| chmod +x ./Ascend-cann-kernels-910b_8.3.RC2_linux-"$(uname -i)".run | ||
| ./Ascend-cann-kernels-910b_8.3.RC2_linux-"$(uname -i)".run --install | ||
|
|
||
| wget --header="Referer: https://www.hiascend.com/" https://ascend-repo.obs.cn-east-2.myhuaweicloud.com/CANN/CANN%208.3.RC1/Ascend-cann-nnal_8.3.RC1_linux-"$(uname -i)".run | ||
| chmod +x ./Ascend-cann-nnal_8.3.RC1_linux-"$(uname -i)".run | ||
| ./Ascend-cann-nnal_8.3.RC1_linux-"$(uname -i)".run --install | ||
| wget --header="Referer: https://www.hiascend.com/" https://ascend-repo.obs.cn-east-2.myhuaweicloud.com/CANN/CANN%208.3.RC2/Ascend-cann-nnal_8.3.RC2_linux-"$(uname -i)".run | ||
| chmod +x ./Ascend-cann-nnal_8.3.RC2_linux-"$(uname -i)".run | ||
| ./Ascend-cann-nnal_8.3.RC2_linux-"$(uname -i)".run --install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commands for downloading and installing the CANN packages are repeated multiple times, which makes the script hard to read and error-prone for future version updates. I suggest using variables for the version and package names to improve maintainability and readability.
| wget --header="Referer: https://www.hiascend.com/" https://ascend-repo.obs.cn-east-2.myhuaweicloud.com/CANN/CANN%208.3.RC2/Ascend-cann-toolkit_8.3.RC2_linux-"$(uname -i)".run | |
| chmod +x ./Ascend-cann-toolkit_8.3.RC2_linux-"$(uname -i)".run | |
| ./Ascend-cann-toolkit_8.3.RC2_linux-"$(uname -i)".run --full | |
| # https://ascend-repo.obs.cn-east-2.myhuaweicloud.com/Milan-ASL/Milan-ASL%20V100R001C22B800TP052/Ascend-cann-kernels-910b_8.3.rc2_linux-aarch64.run | |
| source /usr/local/Ascend/ascend-toolkit/set_env.sh | |
| wget --header="Referer: https://www.hiascend.com/" https://ascend-repo.obs.cn-east-2.myhuaweicloud.com/CANN/CANN%208.3.RC1/Ascend-cann-kernels-910b_8.3.RC1_linux-"$(uname -i)".run | |
| chmod +x ./Ascend-cann-kernels-910b_8.3.RC1_linux-"$(uname -i)".run | |
| ./Ascend-cann-kernels-910b_8.3.RC1_linux-"$(uname -i)".run --install | |
| wget --header="Referer: https://www.hiascend.com/" https://ascend-repo.obs.cn-east-2.myhuaweicloud.com/CANN/CANN%208.3.RC2/Ascend-cann-kernels-910b_8.3.RC2_linux-"$(uname -i)".run | |
| chmod +x ./Ascend-cann-kernels-910b_8.3.RC2_linux-"$(uname -i)".run | |
| ./Ascend-cann-kernels-910b_8.3.RC2_linux-"$(uname -i)".run --install | |
| wget --header="Referer: https://www.hiascend.com/" https://ascend-repo.obs.cn-east-2.myhuaweicloud.com/CANN/CANN%208.3.RC1/Ascend-cann-nnal_8.3.RC1_linux-"$(uname -i)".run | |
| chmod +x ./Ascend-cann-nnal_8.3.RC1_linux-"$(uname -i)".run | |
| ./Ascend-cann-nnal_8.3.RC1_linux-"$(uname -i)".run --install | |
| wget --header="Referer: https://www.hiascend.com/" https://ascend-repo.obs.cn-east-2.myhuaweicloud.com/CANN/CANN%208.3.RC2/Ascend-cann-nnal_8.3.RC2_linux-"$(uname -i)".run | |
| chmod +x ./Ascend-cann-nnal_8.3.RC2_linux-"$(uname -i)".run | |
| ./Ascend-cann-nnal_8.3.RC2_linux-"$(uname -i)".run --install | |
| CANN_VERSION="8.3.RC2" | |
| ARCH="$(uname -i)" | |
| TOOLKIT_PKG="Ascend-cann-toolkit_${CANN_VERSION}_linux-${ARCH}.run" | |
| KERNELS_PKG="Ascend-cann-kernels-910b_${CANN_VERSION}_linux-${ARCH}.run" | |
| NNAL_PKG="Ascend-cann-nnal_${CANN_VERSION}_linux-${ARCH}.run" | |
| wget --header="Referer: https://www.hiascend.com/" "https://ascend-repo.obs.cn-east-2.myhuaweicloud.com/CANN/CANN%20${CANN_VERSION}/${TOOLKIT_PKG}" | |
| chmod +x ./${TOOLKIT_PKG} | |
| ./${TOOLKIT_PKG} --full | |
| # https://ascend-repo.obs.cn-east-2.myhuaweicloud.com/Milan-ASL/Milan-ASL%20V100R001C22B800TP052/Ascend-cann-kernels-910b_8.3.rc2_linux-aarch64.run | |
| source /usr/local/Ascend/ascend-toolkit/set_env.sh | |
| wget --header="Referer: https://www.hiascend.com/" "https://ascend-repo.obs.cn-east-2.myhuaweicloud.com/CANN/CANN%20${CANN_VERSION}/${KERNELS_PKG}" | |
| chmod +x ./${KERNELS_PKG} | |
| ./${KERNELS_PKG} --install | |
| wget --header="Referer: https://www.hiascend.com/" "https://ascend-repo.obs.cn-east-2.myhuaweicloud.com/CANN/CANN%20${CANN_VERSION}/${NNAL_PKG}" | |
| chmod +x ./${NNAL_PKG} | |
| ./${NNAL_PKG} --install |
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: MrZ20 <[email protected]>
|
ci failed by known issue, fixed here: #4352 |
What this PR does / why we need it?
Upgrade CANN to 8.3.rc2
Does this PR introduce any user-facing change?
Yes, docker image will use 8.3.RC2
How was this patch tested?