Skip to content

[Bugfix][CI] Update ModelRunnerOutput Params to Sync Upstream Changes #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

shen-shanshan
Copy link
Collaborator

@shen-shanshan shen-shanshan commented Aug 4, 2025

What this PR does / why we need it?

Update ModelRunnerOutput construct params to sync upstream changes.

The param finished_sending and finished_recving was already deprecated when initializing ModelRunnerOutput.

Plus, more updates are needed for kv_connector related code, this PR is just to make sure the basic offline inference can work well.

Does this PR introduce any user-facing change?

How was this patch tested?

@shen-shanshan shen-shanshan changed the title [bugfix] Update ModelRunnerOutput params to sync upstream changes [bugfix] Update ModelRunnerOutput params to sync upstream changes Aug 4, 2025
@shen-shanshan shen-shanshan changed the title [bugfix] Update ModelRunnerOutput params to sync upstream changes [Bugfix] Update ModelRunnerOutput Params to Sync Upstream Changes Aug 4, 2025
@shen-shanshan shen-shanshan changed the title [Bugfix] Update ModelRunnerOutput Params to Sync Upstream Changes [Bugfix][CI] Update ModelRunnerOutput Params to Sync Upstream Changes Aug 4, 2025
Copy link

github-actions bot commented Aug 4, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@wangxiyuan
Copy link
Collaborator

review this one instead #2181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants